Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2908463002:
Enable heap compaction on all 'container' arenas. (Closed)
DescriptionEnable heap compaction on all 'container' arenas.
Reconcile indexing for compactable arenas to always be wrt
the arena index -- it was miscued on setting, using an
offset instead, thereby preventing vector[1-4] arenas from
being considered for compaction.
R=haraken
BUG=726335
Review-Url: https://codereview.chromium.org/2908463002
Cr-Commit-Position: refs/heads/master@{#474966}
Committed: https://chromium.googlesource.com/chromium/src/+/ec3056b0028de68485f6e5c4b6d57f225d334605
Patch Set 1 #Patch Set 2 : handle all-empty pages #Patch Set 3 : disable stress testing #Patch Set 4 : add checks for compaction being activated. #
Messages
Total messages: 33 (27 generated)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Enable heap compaction on all 'container' arenas. Reconcile indexing for compactable arenas to always be wrt the arena index -- it was miscued on setting, using an offset instead, thereby preventing vector[1-4] arenas from being considered for compaction. R= BUG= ========== to ========== Enable heap compaction on all 'container' arenas. Reconcile indexing for compactable arenas to always be wrt the arena index -- it was miscued on setting, using an offset instead, thereby preventing vector[1-4] arenas from being considered for compaction. R= BUG=672030 ==========
Description was changed from ========== Enable heap compaction on all 'container' arenas. Reconcile indexing for compactable arenas to always be wrt the arena index -- it was miscued on setting, using an offset instead, thereby preventing vector[1-4] arenas from being considered for compaction. R= BUG=672030 ========== to ========== Enable heap compaction on all 'container' arenas. Reconcile indexing for compactable arenas to always be wrt the arena index -- it was miscued on setting, using an offset instead, thereby preventing vector[1-4] arenas from being considered for compaction. R= BUG=726335 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
sigbjornf@opera.com changed reviewers: + oilpan-reviews@chromium.org
please take a look.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM. Can we add a test to check that all container arenas are compacted?
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
On 2017/05/25 23:18:42, haraken wrote: > LGTM. > > Can we add a test to check that all container arenas are compacted? Done.
On 2017/05/26 05:53:55, sof wrote: > On 2017/05/25 23:18:42, haraken wrote: > > LGTM. > > > > Can we add a test to check that all container arenas are compacted? > > Done. LGTM
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Enable heap compaction on all 'container' arenas. Reconcile indexing for compactable arenas to always be wrt the arena index -- it was miscued on setting, using an offset instead, thereby preventing vector[1-4] arenas from being considered for compaction. R= BUG=726335 ========== to ========== Enable heap compaction on all 'container' arenas. Reconcile indexing for compactable arenas to always be wrt the arena index -- it was miscued on setting, using an offset instead, thereby preventing vector[1-4] arenas from being considered for compaction. R=haraken BUG=726335 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sigbjornf@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2908463002/#ps60001 (title: "add checks for compaction being activated.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495786757799050,
"parent_rev": "74bb3b85224a01473a0efabf331ebe4e8541ccb8", "commit_rev":
"a6f6be08714980c900390a7fd312a9f80c2ee85c"}
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495786757799050,
"parent_rev": "a89c40e112c18b20534d84678228acbcde10620e", "commit_rev":
"ec3056b0028de68485f6e5c4b6d57f225d334605"}
Message was sent while issue was closed.
Description was changed from ========== Enable heap compaction on all 'container' arenas. Reconcile indexing for compactable arenas to always be wrt the arena index -- it was miscued on setting, using an offset instead, thereby preventing vector[1-4] arenas from being considered for compaction. R=haraken BUG=726335 ========== to ========== Enable heap compaction on all 'container' arenas. Reconcile indexing for compactable arenas to always be wrt the arena index -- it was miscued on setting, using an offset instead, thereby preventing vector[1-4] arenas from being considered for compaction. R=haraken BUG=726335 Review-Url: https://codereview.chromium.org/2908463002 Cr-Commit-Position: refs/heads/master@{#474966} Committed: https://chromium.googlesource.com/chromium/src/+/ec3056b0028de68485f6e5c4b6d5... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/ec3056b0028de68485f6e5c4b6d5... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
