[mus+ash] Removes WmWindow from window_positioning_utils

Removes WmWindow from window_positioning_utils

BUG=722553
TEST=None (refactoring)
TBR=reveman@chromium.org for a trivial change in components/exo.

Review-Url: https://codereview.chromium.org/2908433005
Cr-Commit-Position: refs/heads/master@{#474728}
Committed: https://chromium.googlesource.com/chromium/src/+/5b72981a509569fa37fac74dc2488f57ddbc5930

[varkha, 2017-05-25 15:34:38]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 15:34:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2017-05-25 15:37:22]

varkha@chromium.org changed reviewers:
+ jamescook@chromium.org

[varkha, 2017-05-25 15:37:23]

jamescook@, here is another small piece, PTAL. Thanks!

[commit-bot: I haz the power, 2017-05-25 16:00:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 16:00:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[varkha, 2017-05-25 16:08:22]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 16:08:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2017-05-25 16:10:25]

varkha@chromium.org changed reviewers:
+ msw@chromium.org
- jamescook@chromium.org

[varkha, 2017-05-25 16:10:25]

msw@, can you please take a look (jamescook ooo)? Thanks!

[varkha, 2017-05-25 16:24:52]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 16:25:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2017-05-25 16:25:53]

Patchset #3 (id:40001) has been deleted

[varkha, 2017-05-25 16:28:20]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 16:28:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-05-25 17:19:00]

jamescook@chromium.org changed reviewers:
+ jamescook@chromium.org

[James Cook, 2017-05-25 17:19:01]

LGTM. msw, you don't need to review.

https://codereview.chromium.org/2908433005/diff/60001/ash/wm/window_positioni...
File ash/wm/window_positioning_utils.cc (right):

https://codereview.chromium.org/2908433005/diff/60001/ash/wm/window_positioni...
ash/wm/window_positioning_utils.cc:75: for (aura::Window* child :
window->children())
Thanks for explicitly listing the type.

[varkha, 2017-05-25 18:24:09]

Thanks!

https://codereview.chromium.org/2908433005/diff/60001/ash/wm/window_positioni...
File ash/wm/window_positioning_utils.cc (right):

https://codereview.chromium.org/2908433005/diff/60001/ash/wm/window_positioni...
ash/wm/window_positioning_utils.cc:75: for (aura::Window* child :
window->children())
On 2017/05/25 17:19:01, James Cook (ooo sick) wrote:
> Thanks for explicitly listing the type.

Acknowledged.

[varkha, 2017-05-25 18:25:07]

Description was changed from

==========
Removes WmWindow from window_positioning_utils

BUG=722553
TEST=None (refactoring)
==========

to

==========
Removes WmWindow from window_positioning_utils

BUG=722553
TEST=None (refactoring)
TBR=reveman@chromium.org for a trivial change in components/exo.
==========

[varkha, 2017-05-25 18:25:50]

The CQ bit was unchecked by varkha@chromium.org

[varkha, 2017-05-25 18:25:56]

The CQ bit was checked by varkha@chromium.org

[commit-bot: I haz the power, 2017-05-25 18:26:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 18:51:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495736756832830,
"parent_rev": "64cb46e133a79a6750d7ca0ae5e3847a0979db44", "commit_rev":
"5b72981a509569fa37fac74dc2488f57ddbc5930"}

[commit-bot: I haz the power, 2017-05-25 18:52:04]

Description was changed from

==========
Removes WmWindow from window_positioning_utils

BUG=722553
TEST=None (refactoring)
TBR=reveman@chromium.org for a trivial change in components/exo.
==========

to

==========
Removes WmWindow from window_positioning_utils

BUG=722553
TEST=None (refactoring)
TBR=reveman@chromium.org for a trivial change in components/exo.

Review-Url: https://codereview.chromium.org/2908433005
Cr-Commit-Position: refs/heads/master@{#474728}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b72981a509569fa37fac74dc248...
==========

[commit-bot: I haz the power, 2017-05-25 18:52:06]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5b72981a509569fa37fac74dc248...

[varkha, 2017-05-26 21:13:33]

Description was changed from

==========
Removes WmWindow from window_positioning_utils

BUG=722553
TEST=None (refactoring)
TBR=reveman@chromium.org for a trivial change in components/exo.

Review-Url: https://codereview.chromium.org/2908433005
Cr-Commit-Position: refs/heads/master@{#474728}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b72981a509569fa37fac74dc248...
==========

to

==========
Removes WmWindow from window_positioning_utils

BUG=722553
TEST=None (refactoring)
TBR=reveman@chromium.org for a trivial change in components/exo.

Review-Url: https://codereview.chromium.org/2908433005
Cr-Commit-Position: refs/heads/master@{#474728}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b72981a509569fa37fac74dc248...
==========