Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2908393002: [Sensors] Bindings for RelativeOrientationSensor (Closed)

Created:
3 years, 6 months ago by Mikhail
Modified:
3 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, wanming.lin, blink-reviews, blink-reviews-frames_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] Bindings for RelativeOrientationSensor BUG=661478 Review-Url: https://codereview.chromium.org/2908393002 Cr-Commit-Position: refs/heads/master@{#476320} Committed: https://chromium.googlesource.com/chromium/src/+/5e98276d1f29fbb44d414f20630a2dfb7c376727

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased + comments from Reilly #

Patch Set 3 : Allow runGenericSensorTests() be called several times #

Patch Set 4 : rebased #

Patch Set 5 : updated webexposed tests results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -146 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-network-service View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/sensor/absolute-orientation-sensor.html View 1 chunk +0 lines, -93 lines 0 comments Download
A + third_party/WebKit/LayoutTests/sensor/orientation-sensor.html View 1 2 chunks +48 lines, -37 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js View 1 2 14 chunks +16 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/RelativeOrientationSensor.h View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/RelativeOrientationSensor.cpp View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/RelativeOrientationSensor.idl View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/UseCounterFeature.def View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
Mikhail
PTAL
3 years, 6 months ago (2017-05-30 14:10:43 UTC) #2
Reilly Grant (use Gerrit)
lgtm with a nit https://codereview.chromium.org/2908393002/diff/1/third_party/WebKit/LayoutTests/sensor/orientation-sensor.html File third_party/WebKit/LayoutTests/sensor/orientation-sensor.html (right): https://codereview.chromium.org/2908393002/diff/1/third_party/WebKit/LayoutTests/sensor/orientation-sensor.html#newcode88 third_party/WebKit/LayoutTests/sensor/orientation-sensor.html:88: .then(mockSensor => { return mockSensor.removeConfigurationCalled(); ...
3 years, 6 months ago (2017-05-30 18:41:48 UTC) #3
shalamov
third_party/WebKit/Source/modules/sensor/* third_party/WebKit/LayoutTests/sensor/* lgtm + Reilly's nit
3 years, 6 months ago (2017-05-31 09:15:58 UTC) #4
Mikhail
haraken@, could you PTAL?
3 years, 6 months ago (2017-05-31 10:14:51 UTC) #8
haraken
LGTM
3 years, 6 months ago (2017-05-31 11:10:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908393002/80001
3 years, 6 months ago (2017-06-01 14:38:07 UTC) #22
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 16:34:25 UTC) #25
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/5e98276d1f29fbb44d414f20630a...

Powered by Google App Engine
This is Rietveld 408576698