Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2908383002: WebRTC: Re-enable 30s datachannel telemetry test. (Closed)

Created:
3 years, 6 months ago by ehmaldonado_chromium
Modified:
3 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebRTC: Re-enable 30s datachannel telemetry test. BUG=chromium:726811 Review-Url: https://codereview.chromium.org/2908383002 Cr-Commit-Position: refs/heads/master@{#475797} Committed: https://chromium.googlesource.com/chromium/src/+/0e5657e03379575203b9617d955e1c410d3db7f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M tools/perf/page_sets/webrtc_cases.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
ehmaldonado_chromium
PTAL. multiple_peerconnections is no longer failing.
3 years, 6 months ago (2017-05-30 14:02:59 UTC) #2
ehmaldonado_chromium
On 2017/05/30 14:02:59, ehmaldonado_chromium wrote: > PTAL. > multiple_peerconnections is no longer failing. Should I ...
3 years, 6 months ago (2017-05-30 14:03:18 UTC) #3
nednguyen
lgtm On 2017/05/30 14:03:18, ehmaldonado_chromium wrote: > On 2017/05/30 14:02:59, ehmaldonado_chromium wrote: > > PTAL. ...
3 years, 6 months ago (2017-05-30 14:04:53 UTC) #4
charliea (OOO until 10-5)
lgtm
3 years, 6 months ago (2017-05-30 16:02:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908383002/1
3 years, 6 months ago (2017-05-31 03:02:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0e5657e03379575203b9617d955e1c410d3db7f2
3 years, 6 months ago (2017-05-31 04:24:06 UTC) #10
mikecase (-- gone --)
This test seems to be timing out on many of the desktop perf bots causing ...
3 years, 6 months ago (2017-06-06 22:48:45 UTC) #12
mikecase (-- gone --)
3 years, 6 months ago (2017-06-06 22:49:43 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2927673002/ by mikecase@chromium.org.

The reason for reverting is: Test timing out on many of the Desktop perf bots
such as...

Linux Perf
Mac 10.11 Perf.Mac Pro 10.11Perf
Win 7 Interl GPU Perf

and about 10 more..

Powered by Google App Engine
This is Rietveld 408576698