Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: components/version_ui/resources/about_version.html

Issue 2908353003: [i18n] components directory to $i18n{} (Closed)
Patch Set: handle blank cohort name Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/version_ui/resources/about_version.html
diff --git a/components/version_ui/resources/about_version.html b/components/version_ui/resources/about_version.html
index 19a261c948fc0b97c50662ba7b24aaad3cae37d4..c19c5f87a04f4d2c9308eb559e84a4f34eefb0a3 100644
--- a/components/version_ui/resources/about_version.html
+++ b/components/version_ui/resources/about_version.html
@@ -4,10 +4,10 @@
about:version template page
-->
-<html id="t" i18n-values="dir:textdirection;lang:language">
+<html id="t" dir="$i18n{textdirection}" lang="$i18n{language}">
<head>
<meta charset="utf-8">
- <title i18n-content="title"></title>
+ <title>$i18n{title}</title>
<link rel="stylesheet" href="chrome://resources/css/text_defaults.css">
<if expr="is_android or is_ios">
<meta name="viewport" content="width=device-width">
@@ -40,66 +40,66 @@ about:version template page
<if expr="is_ios or is_android">
<img src="../../../components/resources/default_100_percent/%DISTRIBUTION%/product_logo.png">
</if>
- <div id="company" i18n-content="company"></div>
- <div id="copyright" i18n-content="copyright"></div>
+ <div id="company">$i18n{company}</div>
+ <div id="copyright">$i18n{copyright}</div>
</div>
<table id="inner" cellpadding="0" cellspacing="0" border="0">
- <tr><td class="label" i18n-content="application_label"></td>
+ <tr><td class="label">$i18n{application_label}</td>
<td class="version" id="version">
- <span i18n-content="version"></span>
- (<span i18n-content="official"></span>)
- <span i18n-content="version_modifier"></span>
- <span i18n-content="version_bitsize"></span>
+ <span>$i18n{version}</span>
+ (<span>$i18n{official}</span>)
+ <span>$i18n{version_modifier}</span>
+ <span>$i18n{version_bitsize}</span>
<if expr="is_win">
- <span i18n-content="update_cohort_name"></span>
+ <span>$i18n{update_cohort_name}</span>
</if>
</td>
</tr>
<tr>
- <td class="label" i18n-content="revision"></td>
+ <td class="label">$i18n{revision}</td>
<td class="version">
- <span i18n-content="cl"></span>
+ <span>$i18n{cl}</span>
</td>
</tr>
<if expr="not chromeos">
<tr>
- <td class="label" i18n-content="os_name"></td>
+ <td class="label">$i18n{os_name}</td>
<td class="version" id="os_type">
- <span i18n-content="os_type"></span>
+ <span>$i18n{os_type}</span>
<if expr="is_android">
- <span i18n-content="os_version"></span>
+ <span>$i18n{os_version}</span>
</if>
</td>
</tr>
</if>
<if expr="is_android">
<tr>
- <td class="label" i18n-content="gms_name"></td>
+ <td class="label">$i18n{gms_name}</td>
<td class="version" id="gms_version">
- <span i18n-content="gms_version"></span>
+ <span>$i18n{gms_version}</span>
</td>
</tr>
</if>
<if expr="chromeos">
<tr>
- <td class="label" i18n-content="platform"></td>
+ <td class="label">$i18n{platform}</td>
<td class="version" id="os_type">
<span id="os_version"></span>
</td>
</tr>
<tr>
- <td class="label" i18n-content="firmware_version"></td>
+ <td class="label">$i18n{firmware_version}</td>
<td class="version">
<span id="firmware_version"></span>
</td>
</tr>
<tr id="customization_id_holder" hidden>
- <td class="label" i18n-content="customization_id"></td>
+ <td class="label">$i18n{customization_id}</td>
<td class="version">
<span id="customization_id"></span>
</td>
</tr>
- <tr id="arc_holder"><td class="label" i18n-content="arc_label"></td>
+ <tr id="arc_holder"><td class="label">$i18n{arc_label}</td>
<td class="version">
<span id="arc_version"></span>
</td>
@@ -108,38 +108,38 @@ about:version template page
<if expr="not is_ios">
<tr><td class="label">JavaScript</td>
<td class="version" id="js_engine">
- <span i18n-content="js_engine"></span>
- <span i18n-content="js_version"></span>
+ <span>$i18n{js_engine}</span>
+ <span>$i18n{js_version}</span>
</td>
</tr>
</if>
<if expr="not is_android and not is_ios">
- <tr><td class="label" i18n-content="flash_plugin"></td>
- <td class="version" id="flash_version" i18n-content="flash_version"></td>
+ <tr><td class="label">$i18n{flash_plugin}</td>
+ <td class="version" id="flash_version">$i18n{flash_version}</td>
</tr>
</if>
- <tr><td class="label" i18n-content="user_agent_name"></td>
- <td class="version" id="useragent" i18n-content="useragent"></td>
+ <tr><td class="label">$i18n{user_agent_name}</td>
+ <td class="version" id="useragent">$i18n{useragent}</td>
</tr>
- <tr><td class="label" i18n-content="command_line_name"></td>
- <td class="version" id="command_line" i18n-content="command_line"></td>
+ <tr><td class="label">$i18n{command_line_name}</td>
+ <td class="version" id="command_line">$i18n{command_line}</td>
</tr>
<if expr="not is_ios">
- <tr><td class="label" i18n-content="executable_path_name"></td>
- <td class="version" id="executable_path" i18n-content="executable_path"></td>
+ <tr><td class="label">$i18n{executable_path_name}</td>
+ <td class="version" id="executable_path">$i18n{executable_path}</td>
</tr>
- <tr><td class="label" i18n-content="profile_path_name"></td>
- <td class="version" id="profile_path" i18n-content="profile_path"></td>
+ <tr><td class="label">$i18n{profile_path_name}</td>
+ <td class="version" id="profile_path">$i18n{profile_path}</td>
</tr>
</if>
<tr id="variations-section">
- <td class="label" i18n-content="variations_name"></td>
+ <td class="label">$i18n{variations_name}</td>
<td class="version" id="variations-list"></td>
</tr>
<if expr="is_win">
<tr id="compiler-section">
<td class="label">Compiler</td>
- <td class="version" id="compiler" i18n-content="compiler"></td>
+ <td class="version" id="compiler">$i18n{compiler}</td>
</tr>
</if>
</table>

Powered by Google App Engine
This is Rietveld 408576698