chrome/browser/ui/webui/version_ui.cc - Issue 2908353003: [i18n] components directory to $i18n{}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/version_ui.cc

Issue 2908353003: [i18n] components directory to $i18n{} (Closed)

Patch Set: handle blank cohort name Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/version_ui.cc

diff --git a/chrome/browser/ui/webui/version_ui.cc b/chrome/browser/ui/webui/version_ui.cc

index 81fe7b3ebf7a3054fa3d6d9c069c71247f410cf1..2ef9c38209837940e9973340c8c0382c3a645a87 100644

--- a/chrome/browser/ui/webui/version_ui.cc

+++ b/chrome/browser/ui/webui/version_ui.cc

@@ -162,6 +162,8 @@ WebUIDataSource* CreateVersionUIDataSource() {

html_source->AddString(version_ui::kUpdateCohortName,

l10n_util::GetStringFUTF16(

IDS_VERSION_UI_COHORT_NAME, update_cohort_name));

+ } else {

+ html_source->AddString(version_ui::kUpdateCohortName, std::string());

Lei Zhang 2017/06/17 06:23:15 Is this because $i18n{update_cohort_name} cannot t

dschuyler 2017/06/19 19:24:53 It is by design that $i18n won't allow the mistake

}

#endif // defined(OS_WIN)

« no previous file with comments | « no previous file | components/chrome_apps/webstore_widget/app/main.html » ('j') | no next file with comments »