Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: components/supervised_user_error_page/supervised_user_error_page_unittest.cc

Issue 2908353003: [i18n] components directory to $i18n{} (Closed)
Patch Set: handle blank cohort name Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/supervised_user_error_page/supervised_user_error_page_unittest.cc
diff --git a/components/supervised_user_error_page/supervised_user_error_page_unittest.cc b/components/supervised_user_error_page/supervised_user_error_page_unittest.cc
index 7565ff4b03d407b7577f517c7a2cc7fe20b93179..41a60493733853b81a89451b94a9cb8502febfd7 100644
--- a/components/supervised_user_error_page/supervised_user_error_page_unittest.cc
+++ b/components/supervised_user_error_page/supervised_user_error_page_unittest.cc
@@ -76,14 +76,10 @@ TEST_P(SupervisedUserErrorPageTest_BuildHtml, BuildHtml) {
param.profile_image_url2, param.custodian, param.custodian_email,
param.second_custodian, param.second_custodian_email,
param.is_child_account, param.reason, "");
- // The result should contain the original HTML plus scripts that plug values
- // into it. The test can't easily check that the scripts are correct, but
- // can check that the output contains the expected values.
- std::string html =
- ResourceBundle::GetSharedInstance()
- .GetRawDataResource(IDR_SUPERVISED_USER_BLOCK_INTERSTITIAL_HTML)
- .as_string();
- EXPECT_THAT(result, testing::HasSubstr(html));
+ // The result should contain the original HTML (with $i18n{} replacements)
+ // plus scripts that plug values into it. The test can't easily check that the
+ // scripts are correct, but can check that the output contains the expected
+ // values.
EXPECT_THAT(result, testing::HasSubstr(param.profile_image_url));
EXPECT_THAT(result, testing::HasSubstr(param.profile_image_url2));
EXPECT_THAT(result, testing::HasSubstr(param.custodian));

Powered by Google App Engine
This is Rietveld 408576698