Create automation test for the new translate infobar

Create automation test for the new translate infobar
The automation test will check if:
1. the new translation infobar appears
2. there are at least 2 tabs
3. overflow menus could be shown
4. overflow menu dismiss upon orientation

BUG=727203
Review-Url: https://codereview.chromium.org/2908253002
Cr-Commit-Position: refs/heads/master@{#476152}
Committed: https://chromium.googlesource.com/chromium/src/+/61372933b5618792e4aacc9907d4e602787a749a

[Marti Wong, 2017-05-30 01:10:24]

Patchset #1 (id:1) has been deleted

[Marti Wong, 2017-05-30 01:27:28]

Patchset #1 (id:20001) has been deleted

[Marti Wong, 2017-05-30 01:29:14]

martiw@chromium.org changed reviewers:
+ googleo@google.com

[Marti Wong, 2017-05-30 01:29:15]

hi Leo, PTAL.
thx

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
(right):

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java:415:
/**
for TranslateCompactInfoBarTest to know if menu is showing.

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/java_sou...
File chrome/android/java_sources.gni (right):

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/java_sou...
chrome/android/java_sources.gni:1640:
"javatests/src/org/chromium/chrome/browser/translate/TranslateCompactInfoBarTest.java",
It seems to me it is better to create a separate file for compact infobar test.

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateCompactInfoBarTest.java
(right):

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateCompactInfoBarTest.java:42:
public class TranslateCompactInfoBarTest {
TranslateCompactInfoBarTest.java is created by copying TranslateInfoBarTest.java
but all the old tests removed.

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateCompactInfoBarTest.java:82:
TranslateUtil.assertHasAtLeastTwoLanguageTabs((TranslateCompactInfoBar)
infoBar);
In this CL, I just check if there is 2 tabs.
To test the clicking of Tab(s) and showing of snackbars, 
we need to mock the native infobar.
I need advice on how to do the mocking.  We might do that in another CL.

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateCompactInfoBarTest.java:117:
public void testTabMenuDismissedOnOrientationChange() throws Exception {
Please advice if we should merge the orientation test with the test above.

https://codereview.chromium.org/2908253002/diff/40001/chrome/test/android/jav...
File
chrome/test/android/javatests/src/org/chromium/chrome/test/util/InfoBarUtil.java
(right):

https://codereview.chromium.org/2908253002/diff/40001/chrome/test/android/jav...
chrome/test/android/javatests/src/org/chromium/chrome/test/util/InfoBarUtil.java:25:
public static boolean findButton(InfoBar infoBar, int buttonId, boolean click) {
Set this to public so that TranslateUtil.java could reuse this.

[Marti Wong, 2017-05-30 04:32:31]

martiw@chromium.org changed reviewers:
+ googleo@chromium.org
- googleo@google.com

[Marti Wong, 2017-05-30 04:32:32]

PTAL  thx!

[Marti Wong, 2017-05-30 07:54:46]

martiw@chromium.org changed reviewers:
+ mdjones@chromium.org

[Marti Wong, 2017-05-30 07:54:47]

Hi Matthew, PTAL.
thx again.

[mdjones, 2017-05-30 16:50:41]

lgtm % suggestion

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
(right):

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java:415:
/**
On 2017/05/30 01:29:15, Marti Wong wrote:
> for TranslateCompactInfoBarTest to know if menu is showing.

If these methods are exclusively for testing, consider adding *ForTesting to
them so its clear and no one is tempted to use them.

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateCompactInfoBarTest.java
(right):

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateCompactInfoBarTest.java:82:
TranslateUtil.assertHasAtLeastTwoLanguageTabs((TranslateCompactInfoBar)
infoBar);
On 2017/05/30 01:29:15, Marti Wong wrote:
> In this CL, I just check if there is 2 tabs.
> To test the clicking of Tab(s) and showing of snackbars, 
> we need to mock the native infobar.
> I need advice on how to do the mocking.  We might do that in another CL.

I'm probably the wrong person to ask about this, but in the past I've overridden
the methods or introduced a native delegate. Doing that work in a separate CL is
fine.

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateCompactInfoBarTest.java:117:
public void testTabMenuDismissedOnOrientationChange() throws Exception {
On 2017/05/30 01:29:15, Marti Wong wrote:
> Please advice if we should merge the orientation test with the test above.

Since these are testing two separate concepts, I thing two tests is fine.

[Marti Wong, 2017-05-31 04:10:18]

martiw@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Marti Wong, 2017-05-31 04:10:19]

Thanks Matthew!

Hi Dan, PTAL.
Need owner's LGTM. thx!

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
(right):

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java:415:
/**
On 2017/05/30 16:50:41, mdjones wrote:
> On 2017/05/30 01:29:15, Marti Wong wrote:
> > for TranslateCompactInfoBarTest to know if menu is showing.
> 
> If these methods are exclusively for testing, consider adding *ForTesting to
> them so its clear and no one is tempted to use them.

Done.

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateCompactInfoBarTest.java
(right):

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateCompactInfoBarTest.java:82:
TranslateUtil.assertHasAtLeastTwoLanguageTabs((TranslateCompactInfoBar)
infoBar);
On 2017/05/30 16:50:41, mdjones wrote:
> On 2017/05/30 01:29:15, Marti Wong wrote:
> > In this CL, I just check if there is 2 tabs.
> > To test the clicking of Tab(s) and showing of snackbars, 
> > we need to mock the native infobar.
> > I need advice on how to do the mocking.  We might do that in another CL.
> 
> I'm probably the wrong person to ask about this, but in the past I've
overridden
> the methods or introduced a native delegate. Doing that work in a separate CL
is
> fine.

Thanks for the advice.

https://codereview.chromium.org/2908253002/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateCompactInfoBarTest.java:117:
public void testTabMenuDismissedOnOrientationChange() throws Exception {
On 2017/05/30 16:50:41, mdjones wrote:
> On 2017/05/30 01:29:15, Marti Wong wrote:
> > Please advice if we should merge the orientation test with the test above.
> 
> Since these are testing two separate concepts, I thing two tests is fine.

Thanks!

[gone, 2017-05-31 17:09:20]

rs lgtm

mdjones already reviewed

[Marti Wong, 2017-06-01 00:10:40]

On 2017/05/31 17:09:20, dfalcantara wrote:
> rs lgtm
> 
> mdjones already reviewed

Thanks!

[Marti Wong, 2017-06-01 00:11:08]

The CQ bit was checked by martiw@chromium.org

[Marti Wong, 2017-06-01 00:11:08]

The patchset sent to the CQ was uploaded after l-g-t-m from mdjones@chromium.org
Link to the patchset: https://codereview.chromium.org/2908253002/#ps60001
(title: "rename functions")

[commit-bot: I haz the power, 2017-06-01 00:12:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 02:09:09]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496275868413840,
"parent_rev": "ea73b1f7ddc1a243ad5886a2aa909f91eb492974", "commit_rev":
"61372933b5618792e4aacc9907d4e602787a749a"}

[commit-bot: I haz the power, 2017-06-01 02:09:18]

Description was changed from

==========
Create automation test for the new translate infobar
The automation test will check if:
1. the new translation infobar appears
2. there are at least 2 tabs
3. overflow menus could be shown
4. overflow menu dismiss upon orientation

BUG=727203
==========

to

==========
Create automation test for the new translate infobar
The automation test will check if:
1. the new translation infobar appears
2. there are at least 2 tabs
3. overflow menus could be shown
4. overflow menu dismiss upon orientation

BUG=727203

Review-Url: https://codereview.chromium.org/2908253002
Cr-Commit-Position: refs/heads/master@{#476152}
Committed:
https://chromium.googlesource.com/chromium/src/+/61372933b5618792e4aacc9907d4...
==========

[commit-bot: I haz the power, 2017-06-01 02:09:21]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/61372933b5618792e4aacc9907d4...