Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1353)

Unified Diff: net/quic/chromium/bidirectional_stream_quic_impl.h

Issue 2908243002: Remove QuicChromiumClientStream::Delegate in favor of async methods. (Closed)
Patch Set: Async errors Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/bidirectional_stream_quic_impl.h
diff --git a/net/quic/chromium/bidirectional_stream_quic_impl.h b/net/quic/chromium/bidirectional_stream_quic_impl.h
index 3b25309c71adcb075d23b516ddae4205219d2442..197cd2341c3ead3cbc994f56c51bd934a7671f9a 100644
--- a/net/quic/chromium/bidirectional_stream_quic_impl.h
+++ b/net/quic/chromium/bidirectional_stream_quic_impl.h
@@ -29,8 +29,7 @@ struct BidirectionalStreamRequestInfo;
class IOBuffer;
class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
- : public BidirectionalStreamImpl,
- public QuicChromiumClientStream::Delegate {
+ : public BidirectionalStreamImpl {
public:
explicit BidirectionalStreamQuicImpl(
std::unique_ptr<QuicChromiumClientSession::Handle> session);
@@ -57,10 +56,6 @@ class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
bool GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const override;
private:
- // QuicChromiumClientStream::Delegate implementation:
- void OnClose() override;
- void OnError(int error) override;
-
void OnStreamReady(int rv);
void OnSendDataComplete(int rv);
void OnReadInitialHeadersComplete(int rv);
@@ -92,6 +87,7 @@ class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
LoadTimingInfo::ConnectTiming connect_timing_;
SpdyHeaderBlock initial_headers_;
+ bool expect_trailers_;
xunjieli 2017/05/31 00:25:22 Can you add a comment on what this bool does? It's
Ryan Hamilton 2017/05/31 02:49:55 Done.
SpdyHeaderBlock trailing_headers_;
// User provided read buffer for ReadData() response.

Powered by Google App Engine
This is Rietveld 408576698