Remove QuicChromiumClientStream::Delegate in favor of async methods.

net/quic/chromium/bidirectional_stream_quic_impl.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_CHROMIUM_BIDIRECTIONAL_STREAM_QUIC_IMPL_H_
 #define NET_QUIC_CHROMIUM_BIDIRECTIONAL_STREAM_QUIC_IMPL_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 11 matching lines @@
 namespace base {
 class Timer;
 }  // namespace base
 
 namespace net {
 
 struct BidirectionalStreamRequestInfo;
 class IOBuffer;
 
 class NET_EXPORT_PRIVATE BidirectionalStreamQuicImpl
-    : public BidirectionalStreamImpl,
-      public QuicChromiumClientStream::Delegate {
+    : public BidirectionalStreamImpl {
  public:
   explicit BidirectionalStreamQuicImpl(
       std::unique_ptr<QuicChromiumClientSession::Handle> session);
 
   ~BidirectionalStreamQuicImpl() override;
 
   // BidirectionalStreamImpl implementation:
   void Start(const BidirectionalStreamRequestInfo* request_info,
              const NetLogWithSource& net_log,
              bool send_request_headers_automatically,
              BidirectionalStreamImpl::Delegate* delegate,
              std::unique_ptr<base::Timer> timer) override;
   void SendRequestHeaders() override;
   int ReadData(IOBuffer* buffer, int buffer_len) override;
   void SendData(const scoped_refptr<IOBuffer>& data,
                 int length,
                 bool end_stream) override;
   void SendvData(const std::vector<scoped_refptr<IOBuffer>>& buffers,
                  const std::vector<int>& lengths,
                  bool end_stream) override;
   NextProto GetProtocol() const override;
   int64_t GetTotalReceivedBytes() const override;
   int64_t GetTotalSentBytes() const override;
   bool GetLoadTimingInfo(LoadTimingInfo* load_timing_info) const override;
 
  private:
-  // QuicChromiumClientStream::Delegate implementation:
-  void OnClose() override;
-  void OnError(int error) override;
-
   void OnStreamReady(int rv);
   void OnSendDataComplete(int rv);
   void OnReadInitialHeadersComplete(int rv);
   void ReadTrailingHeaders();
   void OnReadTrailingHeadersComplete(int rv);
   void OnReadDataComplete(int rv);
 
   // Notifies the delegate of an error.
   void NotifyError(int error);
   // Notifies the delegate that the stream is ready.
@@ skipping 11 matching lines @@
   // will be used as the final response.
   int response_status_;
 
   // The protocol that is negotiated.
   NextProto negotiated_protocol_;
   // Connect timing information for this stream. Populated when headers are
   // received.
   LoadTimingInfo::ConnectTiming connect_timing_;
 
   SpdyHeaderBlock initial_headers_;
+  bool expect_trailers_;

[xunjieli, 2017/05/31 00:25:22]

Can you add a comment on what this bool does? It's not immediately obvious why
it is needed.

[Ryan Hamilton, 2017/05/31 02:49:55]

Done.

   SpdyHeaderBlock trailing_headers_;
 
   // User provided read buffer for ReadData() response.
   scoped_refptr<IOBuffer> read_buffer_;
   int read_buffer_len_;
 
   // Number of bytes received by the headers stream on behalf of this stream.
   int64_t headers_bytes_received_;
   // Number of bytes sent by the headers stream on behalf of this stream.
   int64_t headers_bytes_sent_;
@@ skipping 17 matching lines @@
   bool send_request_headers_automatically_;
 
   base::WeakPtrFactory<BidirectionalStreamQuicImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BidirectionalStreamQuicImpl);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_CHROMIUM_BIDIRECTIONAL_STREAM_QUIC_IMPL_H_