Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2908233002: NetInfo default values (Closed)

Created:
3 years, 6 months ago by tbansal1
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, haraken, jam, blink-reviews, darin-cc_chromium.org, jkarlin+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

NetInfo default values BUG=

Patch Set 1 #

Patch Set 2 : ps #

Patch Set 3 : ps #

Patch Set 4 : ps #

Patch Set 5 : ps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -102 lines) Patch
M content/browser/net_info_browsertest.cc View 1 2 12 chunks +25 lines, -48 lines 0 comments Download
M net/nqe/network_quality_estimator_test_util.h View 1 3 chunks +4 lines, -10 lines 0 comments Download
M net/nqe/network_quality_estimator_test_util.cc View 1 3 chunks +6 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp View 1 2 3 4 4 chunks +35 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 26 (26 generated)
tbansal1
Description was changed from ========== w BUG= ========== to ========== NetInfo default values BUG= ==========
3 years, 6 months ago (2017-05-29 20:26:55 UTC) #1
tbansal1
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-05-29 20:26:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908233002/1
3 years, 6 months ago (2017-05-29 20:27:12 UTC) #3
tbansal1
Patchset #2 (id:20001) has been deleted
3 years, 6 months ago (2017-05-29 21:33:47 UTC) #4
tbansal1
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-05-29 21:33:52 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908233002/40001
3 years, 6 months ago (2017-05-29 21:34:06 UTC) #6
tbansal1
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-05-29 21:43:56 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908233002/60001
3 years, 6 months ago (2017-05-29 21:44:08 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-05-29 22:49:32 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/438452)
3 years, 6 months ago (2017-05-29 22:49:33 UTC) #10
tbansal1
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-05-29 23:45:04 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908233002/70005
3 years, 6 months ago (2017-05-29 23:45:11 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-05-30 00:53:05 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/465215)
3 years, 6 months ago (2017-05-30 00:53:06 UTC) #14
tbansal1
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-05-30 01:41:25 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908233002/90001
3 years, 6 months ago (2017-05-30 01:41:36 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-05-30 03:06:54 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/437055)
3 years, 6 months ago (2017-05-30 03:06:55 UTC) #18
tbansal1
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-05-30 04:47:20 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908233002/90001
3 years, 6 months ago (2017-05-30 04:47:48 UTC) #20
tbansal1
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-05-30 05:12:07 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908233002/110001
3 years, 6 months ago (2017-05-30 05:12:24 UTC) #22
tbansal1
Patchset #6 (id:110001) has been deleted
3 years, 6 months ago (2017-05-30 05:14:17 UTC) #23
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/279895) android_cronet on ...
3 years, 6 months ago (2017-05-30 05:15:00 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-05-30 07:07:15 UTC) #25
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 07:07:15 UTC) #26 
Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698