Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: net/nqe/network_quality_estimator_test_util.cc

Issue 2908233002: NetInfo default values (Closed)
Patch Set: ps Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/network_quality_estimator_test_util.cc
diff --git a/net/nqe/network_quality_estimator_test_util.cc b/net/nqe/network_quality_estimator_test_util.cc
index 051b68107d89ef637a3fed46be2b7263493bc1fe..0c5074e86be70a08213b0797512987bc734be770 100644
--- a/net/nqe/network_quality_estimator_test_util.cc
+++ b/net/nqe/network_quality_estimator_test_util.cc
@@ -50,22 +50,6 @@ TestNetworkQualityEstimator::TestNetworkQualityEstimator(
bool allow_smaller_responses_for_tests,
bool add_default_platform_observations,
std::unique_ptr<BoundTestNetLog> net_log)
- : TestNetworkQualityEstimator(std::move(external_estimate_provider),
- variation_params,
- allow_local_host_requests_for_tests,
- allow_smaller_responses_for_tests,
- add_default_platform_observations,
- false,
- std::move(net_log)) {}
-
-TestNetworkQualityEstimator::TestNetworkQualityEstimator(
- std::unique_ptr<net::ExternalEstimateProvider> external_estimate_provider,
- const std::map<std::string, std::string>& variation_params,
- bool allow_local_host_requests_for_tests,
- bool allow_smaller_responses_for_tests,
- bool add_default_platform_observations,
- bool suppress_notifications_for_testing,
- std::unique_ptr<BoundTestNetLog> net_log)
: NetworkQualityEstimator(std::move(external_estimate_provider),
variation_params,
allow_local_host_requests_for_tests,
@@ -76,7 +60,7 @@ TestNetworkQualityEstimator::TestNetworkQualityEstimator(
accuracy_recording_intervals_set_(false),
rand_double_(0.0),
embedded_test_server_(base::FilePath(kTestFilePath)),
- suppress_notifications_for_testing_(suppress_notifications_for_testing),
+ suppress_notifications_for_testing_(false),
net_log_(std::move(net_log)) {
// Set up the embedded test server.
EXPECT_TRUE(embedded_test_server_.Start());
@@ -296,6 +280,11 @@ nqe::internal::NetworkID TestNetworkQualityEstimator::GetCurrentNetworkID()
return nqe::internal::NetworkID(current_network_type_, current_network_id_);
}
+void TestNetworkQualityEstimator::SetSuppressNotificationsForTesting(
+ bool suppress_notifications_for_testing) {
+ suppress_notifications_for_testing_ = suppress_notifications_for_testing;
+}
+
TestNetworkQualityEstimator::LocalHttpTestServer::LocalHttpTestServer(
const base::FilePath& document_root) {
AddDefaultHandlers(document_root);
« no previous file with comments | « net/nqe/network_quality_estimator_test_util.h ('k') | third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698