Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 2908203002: Condition effectiveType as RuntimeEnabled feature (Closed)

Created:
3 years, 6 months ago by tbansal1
Modified:
3 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, jkarlin+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Condition effectiveType as RuntimeEnabled feature This was missed by mistake in a previous CL. BUG=727285 Review-Url: https://codereview.chromium.org/2908203002 Cr-Commit-Position: refs/heads/master@{#475416} Committed: https://chromium.googlesource.com/chromium/src/+/777d7bc8272145d4221ed2428ca8e3680421c624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/netinfo/NetworkInformation.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
tbansal1
haraken: ptal. Thanks.
3 years, 6 months ago (2017-05-29 18:04:57 UTC) #4
haraken
LGTM
3 years, 6 months ago (2017-05-30 00:50:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908203002/1
3 years, 6 months ago (2017-05-30 01:15:00 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 03:34:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/777d7bc8272145d4221ed2428ca8...

Powered by Google App Engine
This is Rietveld 408576698