Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2908163002:
Photo Picker Dialog: Make sure Back button fires the Cancel action. (Closed)
DescriptionPhoto Picker Dialog: Make sure Back button fires the Cancel action.
BUG=656015
Review-Url: https://codereview.chromium.org/2908163002
Cr-Commit-Position: refs/heads/master@{#475473}
Committed: https://chromium.googlesource.com/chromium/src/+/1cef8a48c31a4922256a092c91c8dc02f7d8a2bd
Patch Set 1 #Patch Set 2 : Sync to latest #Messages
Total messages: 19 (15 generated)
The CQ bit was checked by finnur@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Photo Picker Dialog: Make sure Back button fires the Cancel action. BUG=656015 ========== to ========== Photo Picker Dialog: Make sure Back button fires the Cancel action. BUG=656015 ==========
finnur@chromium.org changed reviewers: + tedchoc@chromium.org
Another easy one...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by finnur@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by finnur@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by finnur@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496134859672840,
"parent_rev": "ca02aa30556a6d7d55817a34355bfe6c2e9f4fa8", "commit_rev":
"1cef8a48c31a4922256a092c91c8dc02f7d8a2bd"}
Message was sent while issue was closed.
Description was changed from ========== Photo Picker Dialog: Make sure Back button fires the Cancel action. BUG=656015 ========== to ========== Photo Picker Dialog: Make sure Back button fires the Cancel action. BUG=656015 Review-Url: https://codereview.chromium.org/2908163002 Cr-Commit-Position: refs/heads/master@{#475473} Committed: https://chromium.googlesource.com/chromium/src/+/1cef8a48c31a4922256a092c91c8... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/1cef8a48c31a4922256a092c91c8... |
