It's alive!

pkg/compiler/lib/src/elements/elements.dart

Index: pkg/compiler/lib/src/elements/elements.dart
diff --git a/pkg/compiler/lib/src/elements/elements.dart b/pkg/compiler/lib/src/elements/elements.dart
index c1387a68ba9a8e1136c05e764744e9381f657b57..2c0ac10ffe64fe706b8727aeedc9b07a819feedf 100644
--- a/pkg/compiler/lib/src/elements/elements.dart
+++ b/pkg/compiler/lib/src/elements/elements.dart
@@ -538,7 +538,7 @@ class Elements {
     return isLocal(element);
   }
 
-  static String reconstructConstructorNameSourceString(Element element) {
+  static String reconstructConstructorNameSourceString(FunctionEntity element) {
     if (element.name == '') {
       return element.enclosingClass.name;
     } else {
@@ -547,7 +547,7 @@ class Elements {
   }
 
   // TODO(johnniwinther): Remove this method.
-  static String reconstructConstructorName(Element element) {
+  static String reconstructConstructorName(FunctionEntity element) {

[Siggi Cherem (dart-lang), 2017/05/30 22:10:20]

In the last CL there was a place in namer.dart where you inlined this code.
Maybe we can undo that now?

Also - should we move these two functions elsewhere (not Elements, but somewhere
else?)

In the past I've been told a lot to avoid container classes with plural names
like this one, so my preference would be to make these top-level methods in a
helper library, maybe: elements/entity_utils.dart ?

[Johnni Winther, 2017/05/31 08:19:31]

Done (for the former), added a TODO (for the latter)

     String className = element.enclosingClass.name;
     if (element.name == '') {
       return className;