Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 2908153003: It's alive! (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index a108061fcc54fe41a97e20e29269e51b084b6f11..97ececbf2d984dcdfa70bd0b95b1be502bda6416 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -942,7 +942,9 @@ class JavaScriptBackend {
int programSize = emitter.assembleProgram(namer, closedWorld);
noSuchMethodRegistry.emitDiagnostic(reporter);
int totalMethodCount = generatedCode.length;
- if (totalMethodCount != mirrorsCodegenAnalysis.preMirrorsMethodCount) {
+ // TODO(johnniwinther): Support `preMirrorsMethodCount` for entities.
+ if (mirrorsCodegenAnalysis.preMirrorsMethodCount != null &&
+ totalMethodCount != mirrorsCodegenAnalysis.preMirrorsMethodCount) {
int mirrorCount =
totalMethodCount - mirrorsCodegenAnalysis.preMirrorsMethodCount;
double percentage = (mirrorCount / totalMethodCount) * 100;
@@ -1187,8 +1189,7 @@ class JavaScriptBackend {
/// supported by the backend.
bool enableCodegenWithErrorsIfSupported(Spannable node) => true;
- jsAst.Expression rewriteAsync(
- FunctionElement element, jsAst.Expression code) {
+ jsAst.Expression rewriteAsync(MethodElement element, jsAst.Expression code) {
AsyncRewriterBase rewriter = null;
jsAst.Name name = namer.methodPropertyName(element);
switch (element.asyncMarker) {

Powered by Google App Engine
This is Rietveld 408576698