Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2908143005: cc: Allow SkImage::makeColorSpace to fail (Closed)

Created:
3 years, 6 months ago by ccameron
Modified:
3 years, 6 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, blink-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Allow SkImage::makeColorSpace to fail This can fail because of lazy-decode failing (this is tested by some layout tests, which started crashing with color correct rendering enabled). BUG=727169 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2908143005 Cr-Commit-Position: refs/heads/master@{#475970} Committed: https://chromium.googlesource.com/chromium/src/+/f7b17ca967e855df93193b868a33e4ccf892c163

Patch Set 1 #

Patch Set 2 : Remove extra stuff #

Patch Set 3 : cc: Allow SkImage::makeColorSpace to fail #

Patch Set 4 : Rebase #

Patch Set 5 : cc: Allow SkImage::makeColorSpace to fail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M cc/tiles/software_image_decode_cache.cc View 1 chunk +6 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
ccameron
Fixing bug that was exposed by layout tests...
3 years, 6 months ago (2017-05-30 20:40:01 UTC) #3
vmpstr
lgtm
3 years, 6 months ago (2017-05-31 16:04:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908143005/80001
3 years, 6 months ago (2017-05-31 17:38:55 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 19:07:01 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f7b17ca967e855df93193b868a33...

Powered by Google App Engine
This is Rietveld 408576698