Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2908073006:
Remove "updatecheck" tag when fetching default settings. (Closed)
DescriptionRemove "updatecheck" tag when fetching default settings.
The "updatecheck" tag is unnecessary when we want to fetch default
settings. Additionally its presence causes the servers to infer that
Chrome needs to be updated.
BUG=727829
TBR=vasilii@chromium.org
Review-Url: https://codereview.chromium.org/2908073006
Cr-Commit-Position: refs/heads/master@{#475849}
Committed: https://chromium.googlesource.com/chromium/src/+/944eab08ac07c46cb5ce2406362f7e376e4c4dec
Patch Set 1 #
Messages
Total messages: 24 (17 generated)
The CQ bit was checked by alito@chromium.org
The CQ bit was unchecked by alito@chromium.org
The CQ bit was checked by alito@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
waffles@chromium.org changed reviewers: + waffles@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM. I verified manually with some real brand codes with non-empty default settings that the only difference in the response data is the lack of <updatecheck> tag and some cohort information.
Description was changed from ========== Remove <updatecheck> tag when fetching default settings. The <updatecheck> tag is unnecessary when we want to fetch default settings. Additionally its presence causes the servers to infer that Chrome needs to be updated. BUG= ========== to ========== Remove <updatecheck> tag when fetching default settings. The <updatecheck> tag is unnecessary when we want to fetch default settings. Additionally its presence causes the servers to infer that Chrome needs to be updated. BUG=727829 ==========
engedy@chromium.org changed reviewers: + engedy@chromium.org
Description was changed from ========== Remove <updatecheck> tag when fetching default settings. The <updatecheck> tag is unnecessary when we want to fetch default settings. Additionally its presence causes the servers to infer that Chrome needs to be updated. BUG=727829 ========== to ========== Remove <updatecheck> tag when fetching default settings. The <updatecheck> tag is unnecessary when we want to fetch default settings. Additionally its presence causes the servers to infer that Chrome needs to be updated. BUG=727829 TBR=vasilii@chromium.org ==========
engedy@chromium.org changed reviewers: + vasilii@chromium.org
I have now tested this patch locally with a Chrome-branded official build. I tried several brand codes that have non-empty brand-coded default settings and I'm able to get the same settings from Omaha with and without this change. I've tested both resetting via the settings page and via the reset prompt feature.
Description was changed from ========== Remove <updatecheck> tag when fetching default settings. The <updatecheck> tag is unnecessary when we want to fetch default settings. Additionally its presence causes the servers to infer that Chrome needs to be updated. BUG=727829 TBR=vasilii@chromium.org ========== to ========== Remove "updatecheck" tag when fetching default settings. The <updatecheck> tag is unnecessary when we want to fetch default settings. Additionally its presence causes the servers to infer that Chrome needs to be updated. BUG=727829 TBR=vasilii@chromium.org ==========
Description was changed from ========== Remove "updatecheck" tag when fetching default settings. The <updatecheck> tag is unnecessary when we want to fetch default settings. Additionally its presence causes the servers to infer that Chrome needs to be updated. BUG=727829 TBR=vasilii@chromium.org ========== to ========== Remove "updatecheck" tag when fetching default settings. The "updatecheck" tag is unnecessary when we want to fetch default settings. Additionally its presence causes the servers to infer that Chrome needs to be updated. BUG=727829 TBR=vasilii@chromium.org ==========
Vasilii, PTAL. Feel free to hit the CQ button if this change lgty.
The CQ bit was checked by vasilii@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1496220488774430, "parent_rev":
"094aff3a43e07798e3801c3735ee0cc06fd49be1", "commit_rev":
"944eab08ac07c46cb5ce2406362f7e376e4c4dec"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1496220488774430, "parent_rev":
"094aff3a43e07798e3801c3735ee0cc06fd49be1", "commit_rev":
"944eab08ac07c46cb5ce2406362f7e376e4c4dec"}
Message was sent while issue was closed.
Description was changed from ========== Remove "updatecheck" tag when fetching default settings. The "updatecheck" tag is unnecessary when we want to fetch default settings. Additionally its presence causes the servers to infer that Chrome needs to be updated. BUG=727829 TBR=vasilii@chromium.org ========== to ========== Remove "updatecheck" tag when fetching default settings. The "updatecheck" tag is unnecessary when we want to fetch default settings. Additionally its presence causes the servers to infer that Chrome needs to be updated. BUG=727829 TBR=vasilii@chromium.org Review-Url: https://codereview.chromium.org/2908073006 Cr-Commit-Position: refs/heads/master@{#475849} Committed: https://chromium.googlesource.com/chromium/src/+/944eab08ac07c46cb5ce2406362f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/944eab08ac07c46cb5ce2406362f... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
