Issue 290803002: Return an absolute URL for HTMLImageElement.currentSrc

Issue 290803002: Return an absolute URL for HTMLImageElement.currentSrc (Closed)

Created:
6 years, 7 months ago by Yoav Weiss

Modified:
6 years, 7 months ago

Reviewers:
esprehn, eseidel

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, cbiesinger, zcorpan

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Return an absolute URL for HTMLImageElement.currentSrc Due to a spec change, currentSrc should return an absolute URL. BUG=375148 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174366

Patch Set 1 #

Patch Set 2 : Test that currentSrc is absolute #

Total comments: 5

Patch Set 3 : Rebase and review nits #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -166 lines)			Patch
M	LayoutTests/fast/dom/HTMLImageElement/image-picture-1x.html	View	1 2	1 chunk	+9 lines, -8 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLImageElement/image-picture-1x-expected.txt	View	1 2	1 chunk	+8 lines, -8 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLImageElement/image-picture-invalid.html	View	1 2	1 chunk	+6 lines, -5 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLImageElement/image-picture-invalid-expected.txt	View	1 2	1 chunk	+5 lines, -5 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLImageElement/image-picture-nested.html	View	1 2	1 chunk	+10 lines, -9 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLImageElement/image-picture-nested-expected.txt	View	1 2	1 chunk	+9 lines, -9 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLImageElement/image-sizes-1x.html	View	1 2	1 chunk	+34 lines, -38 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLImageElement/image-sizes-1x-expected.txt	View	1 2	1 chunk	+15 lines, -14 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x.html	View	1 2	1 chunk	+30 lines, -35 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x-expected.txt	View	1 2	1 chunk	+13 lines, -13 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-change.html	View	1 2	2 chunks	+4 lines, -9 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-change-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-innerhtml.html	View	1 2	2 chunks	+4 lines, -9 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-innerhtml-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
A	LayoutTests/fast/dom/HTMLImageElement/resources/currentSrcHelper.js	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLImageElement.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/HTMLImageElement.cpp	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

esprehn

lgtm, please add doctypes to all your tests before landing. https://codereview.chromium.org/290803002/diff/20001/LayoutTests/fast/dom/HTMLImageElement/image-sizes-1x.html File LayoutTests/fast/dom/HTMLImageElement/image-sizes-1x.html (right): https://codereview.chromium.org/290803002/diff/20001/LayoutTests/fast/dom/HTMLImageElement/image-sizes-1x.html#newcode1 ...

6 years, 7 months ago (2014-05-20 06:56:03 UTC) #2

Yoav Weiss

On 2014/05/20 06:56:03, esprehn wrote: > lgtm, please add doctypes to all your tests before ...

6 years, 7 months ago (2014-05-20 09:51:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/290803002/40001

6 years, 7 months ago (2014-05-20 09:52:05 UTC) #5

Message was sent while issue was closed.

Change committed as 174366

Expand Messages | Collapse Messages