Fix new/free mismatch in ActiveTabTest.DelegateIsSet

Fix new/free mismatch in ActiveTabTest.DelegateIsSet

As found by ASAN. The error is from r475128.

BUG=717945
TBR=isandrk@chromium.org

Review-Url: https://codereview.chromium.org/2907953002
Cr-Commit-Position: refs/heads/master@{#475218}
Committed: https://chromium.googlesource.com/chromium/src/+/3a178ffe803c79a0f8a44750c67f17c3cde5a9d6

[Lei Zhang, 2017-05-27 01:25:42]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-27 01:25:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 01:56:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-27 01:56:15]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-05-27 02:00:29]

TBR

[Lei Zhang, 2017-05-27 02:00:33]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2017-05-27 02:00:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 02:05:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495850433762380, "parent_rev":
"4a225601e7fcf2c57ea5376edf1e55e722216343", "commit_rev":
"3a178ffe803c79a0f8a44750c67f17c3cde5a9d6"}

[commit-bot: I haz the power, 2017-05-27 02:05:31]

Description was changed from

==========
Fix new/free mismatch in ActiveTabTest.DelegateIsSet

As found by ASAN. The error is from r475128.

BUG=717945
TBR=isandrk@chromium.org
==========

to

==========
Fix new/free mismatch in ActiveTabTest.DelegateIsSet

As found by ASAN. The error is from r475128.

BUG=717945
TBR=isandrk@chromium.org

Review-Url: https://codereview.chromium.org/2907953002
Cr-Commit-Position: refs/heads/master@{#475218}
Committed:
https://chromium.googlesource.com/chromium/src/+/3a178ffe803c79a0f8a44750c67f...
==========

[commit-bot: I haz the power, 2017-05-27 02:05:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3a178ffe803c79a0f8a44750c67f...

[Ivan Šandrk, 2017-05-29 10:00:31]

Thank you for fixing this Lei!

On 2017/05/27 01:19:42, Lei Zhang wrote:
> free(ActiveTabPermissionGranter::SetPlatformDelegate(nullptr));
> This should be a delete. Have you considered unique_ptrs?

Actually did, this way it seemed simpler to me (I've seen this pattern of
"leaked" pointers elsewhere).