Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2907863002: Remove references to extensions from //components/guest_view/. (Closed)

Created:
3 years, 6 months ago by Kevin McNee
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove references to extensions from //components/guest_view/. We had an assert(enable_extensions) in //components/guest_view/ to prevent the accidental building of GuestViews on mobile, since extensions are currently the only thing using GuestViews. However, referencing extensions here violates layering. This modifies the assert to not reference extensions. BUG=726694 Review-Url: https://codereview.chromium.org/2907863002 Cr-Commit-Position: refs/heads/master@{#475554} Committed: https://chromium.googlesource.com/chromium/src/+/f0a499017741777102444b10bff254e347f96571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M components/BUILD.gn View 3 chunks +4 lines, -5 lines 0 comments Download
M components/guest_view/browser/BUILD.gn View 1 chunk +5 lines, -3 lines 0 comments Download
M components/guest_view/renderer/BUILD.gn View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
Kevin McNee
wjmaclean: Please review changes in components/guest_view blundell: Please review changes in components/BUILD.gn
3 years, 6 months ago (2017-05-26 18:25:55 UTC) #10
wjmaclean
lgtm
3 years, 6 months ago (2017-05-26 18:38:10 UTC) #11
Mostyn Bramley-Moore
non-owner lgtm.
3 years, 6 months ago (2017-05-29 22:40:14 UTC) #12
blundell
//components/BUILD.gn LGTM
3 years, 6 months ago (2017-05-30 05:13:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907863002/1
3 years, 6 months ago (2017-05-30 14:24:07 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/226154)
3 years, 6 months ago (2017-05-30 15:49:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907863002/1
3 years, 6 months ago (2017-05-30 15:53:12 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 16:35:52 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f0a499017741777102444b10bff2...

Powered by Google App Engine
This is Rietveld 408576698