Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2907803002: Fix test OneByteArrayJoin. (Closed)

Created:
3 years, 7 months ago by Ilija.Pavlovic1
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Fix test OneByteArrayJoin. The test OneByteArrayJoin failed on MIPS64 in debug mode after https://chromium-review.googlesource.com/c/489946/ with error messages "allocation failure GC in old space requested" and "Fatal javascript OOM in CALL_AND_RETRY_LAST". Successful test execution is possible on two ways: with flag --max_old_space_size=7 or with modification in the test (constraints.set_max_old_space_size(7)). TEST=cctest/test-strings/OneByteArrayJoin BUG= Review-Url: https://codereview.chromium.org/2907803002 Cr-Commit-Position: refs/heads/master@{#45548} Committed: https://chromium.googlesource.com/v8/v8/+/aa0c8dcc180420e8266351cdabfef4cf38885357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/test-strings.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Ilija.Pavlovic1
PTAL
3 years, 7 months ago (2017-05-26 09:25:04 UTC) #2
Ilija.Pavlovic1
ping
3 years, 6 months ago (2017-05-29 06:14:26 UTC) #3
Benedikt Meurer
lgtm
3 years, 6 months ago (2017-05-29 06:24:43 UTC) #4
Michael Starzinger
LGTM.
3 years, 6 months ago (2017-05-29 07:47:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907803002/1
3 years, 6 months ago (2017-05-29 08:02:33 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 08:30:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/aa0c8dcc180420e8266351cdabfef4cf388...

Powered by Google App Engine
This is Rietveld 408576698