Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 2907793003: Retry BattOr connection serial reads when zero bytes are read (Closed)

Created:
3 years, 7 months ago by charliea (OOO until 10-5)
Modified:
3 years, 7 months ago
Reviewers:
aschulman
CC:
chromium-reviews, rnephew (Reviews Here)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Retry BattOr connection serial reads when zero bytes are read The BattOr connection will now continue to make read attempts until the timeout is imposed by the BattOrAgent by canceling the read. This fixes a Windows bug in which the BattOr agent would request the samples from the BattOr, immediately request a read, receive zero bytes back, fail, and restart StopTracing. TBR=aschulman@chromium.org BUG=726087 Review-Url: https://codereview.chromium.org/2907793003 Cr-Commit-Position: refs/heads/master@{#475169} Committed: https://chromium.googlesource.com/chromium/src/+/e08d9d7cc11ca18f127f900c0e76499fba723c99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M tools/battor_agent/battor_connection_impl.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
charliea (OOO until 10-5)
3 years, 7 months ago (2017-05-26 21:28:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907793003/1
3 years, 7 months ago (2017-05-26 21:43:25 UTC) #6
aschulman
On 2017/05/26 21:43:25, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 7 months ago (2017-05-26 21:43:45 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 22:48:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e08d9d7cc11ca18f127f900c0e76...

Powered by Google App Engine
This is Rietveld 408576698