Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 2907753002: Limit D3D V-sync experiment to Win 8.1+ (Closed)

Created:
3 years, 7 months ago by stanisc
Modified:
3 years, 6 months ago
Reviewers:
jbauman
CC:
chromium-reviews, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Limit D3D V-sync experiment to Win 8.1+ Previously D3D V-sync experiment included Win 8.0 but the initial finch data suggests that it has issues on Win 8.0, for example GPU crash rate is 8 times higher than in the control group. I suspect there is the same internal D3D locking issue that I saw on my Windows 7 workstation. This patch changes the supported Windows version to start with Win 8.1. BUG=726557 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2907753002 Cr-Commit-Position: refs/heads/master@{#475029} Committed: https://chromium.googlesource.com/chromium/src/+/2fde6d35bd484cc0cb9a4b7964f0a5e2cf000a6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/ipc/service/image_transport_surface_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
stanisc
PTAL!
3 years, 7 months ago (2017-05-26 01:26:25 UTC) #6
jbauman
lgtm
3 years, 7 months ago (2017-05-26 01:30:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907753002/1
3 years, 6 months ago (2017-05-26 16:31:11 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 16:37:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2fde6d35bd484cc0cb9a4b7964f0...

Powered by Google App Engine
This is Rietveld 408576698