Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2907683004: Move ClientCompositorFrameSink to components/viz (Closed)

Created:
3 years, 7 months ago by Saman Sami
Modified:
3 years, 7 months ago
Reviewers:
Fady Samuel, sky, piman
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, darin-cc_chromium.org, kalyank, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ClientCompositorFrameSink to components/viz ClientCompositorFrameSink is used by clients to talk to viz and should be a part of the viz component. Currently it's located in an aura-only target which doesn't allow its usage on Mac and Android. BUG=726485 TBR=piman@chromium.org Review-Url: https://codereview.chromium.org/2907683004 Cr-Commit-Position: refs/heads/master@{#475004} Committed: https://chromium.googlesource.com/chromium/src/+/1bcf030241bb52a9ee770c1c94300128f69fbbb9

Patch Set 1 #

Patch Set 2 : c #

Patch Set 3 : c #

Patch Set 4 : c #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -216 lines) Patch
A components/viz/client/BUILD.gn View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
A components/viz/client/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A + components/viz/client/client_compositor_frame_sink.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + components/viz/client/client_compositor_frame_sink.cc View 8 chunks +11 lines, -13 lines 0 comments Download
M content/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/mus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/mus/renderer_window_tree_client.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/mus/renderer_window_tree_client.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/public/cpp/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D services/ui/public/cpp/client_compositor_frame_sink.h View 1 chunk +0 lines, -67 lines 0 comments Download
D services/ui/public/cpp/client_compositor_frame_sink.cc View 1 chunk +0 lines, -121 lines 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/mus/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/mus/window_port_mus.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/mus/window_port_mus.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 41 (31 generated)
Saman Sami
3 years, 7 months ago (2017-05-25 22:31:10 UTC) #9
Fady Samuel
lgtm
3 years, 7 months ago (2017-05-25 22:32:08 UTC) #10
Saman Sami
piman please review content/renderer/DEPS sky please review ui/aura
3 years, 7 months ago (2017-05-25 23:17:32 UTC) #24
sky
LGTM
3 years, 7 months ago (2017-05-25 23:58:30 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907683004/80001
3 years, 7 months ago (2017-05-26 01:36:50 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/303886)
3 years, 7 months ago (2017-05-26 06:07:32 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907683004/80001
3 years, 7 months ago (2017-05-26 11:59:26 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/304190)
3 years, 7 months ago (2017-05-26 13:49:29 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907683004/80001
3 years, 7 months ago (2017-05-26 14:12:40 UTC) #38
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 15:04:33 UTC) #41
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1bcf030241bb52a9ee770c1c9430...

Powered by Google App Engine
This is Rietveld 408576698