Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2907683002: Reland of Add helpful error messages to check_gn_headers.py (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, tfarina, Moe
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add helpful error messages to check_gn_headers.py (patchset #1 id:1 of https://codereview.chromium.org/2905863002/ ) Reason for revert: The real culprit is https://crrev.com/2903733004/, which was reverted. This CL (https://crrev.com/2891363004) made it fail more gracefully, and should be kept. Original issue's description: > Revert of Add helpful error messages to check_gn_headers.py (patchset #3 id:40001 of https://codereview.chromium.org/2891363004/ ) > > Reason for revert: > This CL is likely causing massive failures: > > https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/84473 > to > https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/84498 > > and > > https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/111528 > to > https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/111542 > > Original issue's description: > > Add helpful error messages to check_gn_headers.py > > > > Before running check_gn_headers.py, it is necessary to build all > > in order to get the dependency info from the compiler. Directly > > checking whether rebuilding is needed by running a build dry run > > takes too long, so some heuristics are used instead. > > > > BUG=661774 > > > > Review-Url: https://codereview.chromium.org/2891363004 > > Cr-Commit-Position: refs/heads/master@{#474588} > > Committed: https://chromium.googlesource.com/chromium/src/+/0ceaba5ef538ce1780578d5e948641bc27f5829b > > TBR=dpranke@chromium.org,tfarina@chromium.org,wychen@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=661774 > > Review-Url: https://codereview.chromium.org/2905863002 > Cr-Commit-Position: refs/heads/master@{#474649} > Committed: https://chromium.googlesource.com/chromium/src/+/d3c2681426db53550547f2bc115c3f72ba40f276 TBR=dpranke@chromium.org,tfarina@chromium.org,mahmadi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=661774 Review-Url: https://codereview.chromium.org/2907683002 Cr-Commit-Position: refs/heads/master@{#474786} Committed: https://chromium.googlesource.com/chromium/src/+/0362911661559a7edca7d4ca9c36f1091a527b04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -15 lines) Patch
M build/check_gn_headers.py View 6 chunks +39 lines, -13 lines 0 comments Download
M build/check_gn_headers_unittest.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
wychen
Created Reland of Add helpful error messages to check_gn_headers.py
3 years, 7 months ago (2017-05-25 20:36:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907683002/1
3 years, 7 months ago (2017-05-25 20:36:49 UTC) #3
Dirk Pranke
lgtm
3 years, 7 months ago (2017-05-25 20:37:10 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 20:38:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0362911661559a7edca7d4ca9c36...

Powered by Google App Engine
This is Rietveld 408576698