content/renderer/render_view_browsertest.cc - Issue 2907663004: FrameTree::Find only searches relative to local frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 2907663004: FrameTree::Find only searches relative to local frames. (Closed)

Patch Set: Rebasing... Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_browsertest.cc

diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc

index 54fb6f87a135b64204e281203abeee298fa3edca..a7f6ff2451b345f5a20d57e0beee45a68ccc1575 100644

--- a/content/renderer/render_view_browsertest.cc

+++ b/content/renderer/render_view_browsertest.cc

@@ -1718,7 +1718,7 @@ TEST_F(RenderViewImplTest, NavigateSubframe) {

TestRenderFrame* subframe =

static_cast<TestRenderFrame*>(RenderFrameImpl::FromWebFrame(

- view()->webview()->FindFrameByName("frame")));

+ frame()->GetWebFrame()->FindFrameByName("frame")));

subframe->Navigate(common_params, StartNavigationParams(), request_params);

FrameLoadWaiter(subframe).Wait();