content/renderer/pepper/pepper_plugin_instance_impl.cc - Issue 2907663004: FrameTree::Find only searches relative to local frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.cc

Issue 2907663004: FrameTree::Find only searches relative to local frames. (Closed)

Patch Set: Rebasing... Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/pepper_plugin_instance_impl.cc

diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.cc b/content/renderer/pepper/pepper_plugin_instance_impl.cc

index bddc0aa5007dde1f22ee2316c2b00f8b5d6af86c..cb06ebf83853f4cd8e8b85fba1fc3f060209194a 100644

--- a/content/renderer/pepper/pepper_plugin_instance_impl.cc

+++ b/content/renderer/pepper/pepper_plugin_instance_impl.cc

@@ -3265,7 +3265,7 @@ int32_t PepperPluginInstanceImpl::Navigate(

// In imitation of the NPAPI implementation, only |target_frame == frame| is

// allowed for security reasons.

WebFrame* target_frame =

- frame->View()->FindFrameByName(WebString::FromUTF8(target), frame);

+ frame->FindFrameByName(WebString::FromUTF8(target));

if (target_frame != frame)

return PP_ERROR_NOACCESS;