Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2907663004: FrameTree::Find only searches relative to local frames. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index a8985f8f7f0d01d24468aca6107ea7b50e36f4ae..f27bd952188f53cdfbb7b3e47ab4b33449a3215c 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -2633,19 +2633,6 @@ WebFrame* WebViewImpl::MainFrame() {
return WebFrame::FromFrame(page_ ? page_->MainFrame() : nullptr);
}
-WebFrame* WebViewImpl::FindFrameByName(const WebString& name,
- WebFrame* relative_to_frame) {
- // FIXME: Either this should only deal with WebLocalFrames or it should move
- // to WebFrame.
- if (!relative_to_frame)
- relative_to_frame = MainFrame();
- Frame* frame = ToWebLocalFrameBase(relative_to_frame)->GetFrame();
- frame = frame->Tree().Find(name);
- if (!frame || !frame->IsLocalFrame())
- return nullptr;
- return WebLocalFrameBase::FromFrame(ToLocalFrame(frame));
-}
-
WebLocalFrame* WebViewImpl::FocusedFrame() {
Frame* frame = FocusedCoreFrame();
// TODO(yabinh): focusedCoreFrame() should always return a local frame, and

Powered by Google App Engine
This is Rietveld 408576698