Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2907663004: FrameTree::Find only searches relative to local frames. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 25513bd30a24152b3a9ae62443c657a1b4278e4c..c5626ba0a5bd1df898431072e09daec99f058ec3 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -2016,6 +2016,11 @@ WebLocalFrameImpl* WebLocalFrameImpl::LocalRoot() {
return local_root;
}
+WebFrame* WebLocalFrameImpl::FindFrameByName(const WebString& name) {
+ Frame* result = GetFrame()->Tree().Find(name);
+ return WebFrame::FromFrame(result);
dcheng 2017/05/26 18:28:05 The original helper on WebView only returned local
Łukasz Anforowicz 2017/05/26 20:04:05 I think these 2 concerns (finding a frame by name
+}
+
void WebLocalFrameImpl::SendPings(const WebURL& destination_url) {
DCHECK(GetFrame());
DCHECK(context_menu_node_.Get());

Powered by Google App Engine
This is Rietveld 408576698