third_party/WebKit/Source/core/page/FrameTree.cpp - Issue 2907663004: FrameTree::Find only searches relative to local frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/FrameTree.cpp

Issue 2907663004: FrameTree::Find only searches relative to local frames. (Closed)

Patch Set: . Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/FrameTree.cpp

diff --git a/third_party/WebKit/Source/core/page/FrameTree.cpp b/third_party/WebKit/Source/core/page/FrameTree.cpp

index cb492e67a9a8b82249eb68df941bd2440ceac657..0f045e016e96780dfc1b53d9d08944ae641d65ad 100644

--- a/third_party/WebKit/Source/core/page/FrameTree.cpp

+++ b/third_party/WebKit/Source/core/page/FrameTree.cpp

@@ -149,6 +149,9 @@ unsigned FrameTree::ChildCount() const {

}

Frame* FrameTree::Find(const AtomicString& name) const {

+ // Named frame lookup should always be relative to a local frame.

+ DCHECK(this_frame_->IsLocalFrame());

if (EqualIgnoringASCIICase(name, "_self") ||

EqualIgnoringASCIICase(name, "_current") || name.IsEmpty())

return this_frame_;