Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2907663003: Ensure the services gpu tests run with ozone. (Closed)

Created:
3 years, 7 months ago by Elliot Glaysher
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure the services gpu tests run with ozone. When I moved mus_gpu_unittests into service_unittests, I didn't copy the ozone initialization into the new test runner. BUG=722546 Review-Url: https://codereview.chromium.org/2907663003 Cr-Commit-Position: refs/heads/master@{#474908} Committed: https://chromium.googlesource.com/chromium/src/+/f3d24ad5c4879b43f34cce80a66aa1317c233bc3

Patch Set 1 #

Patch Set 2 : Remove target. #

Patch Set 3 : fix deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -52 lines) Patch
M services/test/BUILD.gn View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M services/test/run_all_service_tests.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M services/ui/common/BUILD.gn View 1 1 chunk +0 lines, -17 lines 0 comments Download
D services/ui/common/run_all_service_tests.cc View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
Elliot Glaysher
Ooops. Who tests the testers?
3 years, 7 months ago (2017-05-25 20:58:54 UTC) #12
sky
LGTM
3 years, 7 months ago (2017-05-25 22:31:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907663003/40001
3 years, 7 months ago (2017-05-25 22:33:50 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 04:48:39 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f3d24ad5c4879b43f34cce80a66a...

Powered by Google App Engine
This is Rietveld 408576698