Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1733)

Issue 2907663002: Rename chrome_exe_main_mac.c to chrome_exe_main_mac.cc (Closed)

Created:
3 years, 7 months ago by Greg K
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename chrome_exe_main_mac.c to chrome_exe_main_mac.cc Converts the chrome_exe_main_mac.c file to C++ for use in a future sandboxing CL, which requires this fill to use C++ code. NOPRESUBMIT=true BUG=689306 Review-Url: https://codereview.chromium.org/2907663002 Cr-Commit-Position: refs/heads/master@{#474804} Committed: https://chromium.googlesource.com/chromium/src/+/4c69297c5da0d7332ee3a24a985fcc0b89ce3cc1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -97 lines) Patch
M chrome/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/app/chrome_exe_main_mac.c View 1 chunk +0 lines, -90 lines 0 comments Download
A + chrome/app/chrome_exe_main_mac.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Greg K
PTAL. Thanks, Greg
3 years, 7 months ago (2017-05-25 19:24:02 UTC) #3
Nico
lgtm
3 years, 7 months ago (2017-05-25 19:43:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907663002/1
3 years, 7 months ago (2017-05-25 21:11:36 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 21:12:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4c69297c5da0d7332ee3a24a985f...

Powered by Google App Engine
This is Rietveld 408576698