Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 2907563003: Revert "[Experiment] Stop suppressing DragEvent" (Closed)

Created:
3 years, 7 months ago by Alan Knight
Modified:
3 years, 7 months ago
Reviewers:
terry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "[Experiment] Stop suppressing DragEvent" This reverts commit fbbb97467030db2f0996e19f3c5bc133851dee31. Also updates the cached_patches.dart file. BUG= R=terry@google.com Committed: https://github.com/dart-lang/sdk/commit/6f71f9c80b2088df5afa5e8ded7196db120f5b18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -308 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 2 chunks +0 lines, -17 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 34 chunks +71 lines, -103 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 36 chunks +91 lines, -130 lines 0 comments Download
M sdk/lib/js/dartium/cached_patches.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 2 chunks +21 lines, -21 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 2 chunks +21 lines, -21 lines 0 comments Download
M tools/dom/idl/dart/dart.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dom/scripts/htmleventgenerator.py View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Alan Knight
Breaks on Safari, which sends MouseEvent for drag operations.
3 years, 7 months ago (2017-05-25 18:11:19 UTC) #2
terry
lgtm
3 years, 7 months ago (2017-05-25 18:15:31 UTC) #3
Alan Knight
3 years, 7 months ago (2017-05-25 18:16:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6f71f9c80b2088df5afa5e8ded7196db120f5b18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698