Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2907553004: DevTools: Avoid typing into ghost text in TextPrompt (Closed)

Created:
3 years, 7 months ago by einbinder
Modified:
3 years, 6 months ago
Reviewers:
dgozman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Avoid typing into ghost text in TextPrompt In an empty text prompt with ghost text visible, the ghost text would capture the first character typed. BUG=none Review-Url: https://codereview.chromium.org/2907553004 Cr-Commit-Position: refs/heads/master@{#475831} Committed: https://chromium.googlesource.com/chromium/src/+/8438d67abe62bc1a7545cc60ec203d3bcee7f5a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
einbinder
ptal
3 years, 7 months ago (2017-05-26 21:13:19 UTC) #2
dgozman
lgtm
3 years, 6 months ago (2017-05-30 18:25:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907553004/1
3 years, 6 months ago (2017-05-31 04:17:27 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 06:41:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8438d67abe62bc1a7545cc60ec20...

Powered by Google App Engine
This is Rietveld 408576698