third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp - Issue 2907543002: Removed use of RefPtr::Release where result is not used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp

Issue 2907543002: Removed use of RefPtr::Release where result is not used. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp b/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp

index 81236d61d7d95c5e82e470606ef80ba3a47ad786..f29620319d165342a83825e71e4cbb6bce86bcb5 100644

--- a/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp

@@ -114,7 +114,7 @@ WorkerOrWorkletScriptController::~WorkerOrWorkletScriptController() {

void WorkerOrWorkletScriptController::Dispose() {

rejected_promises_->Dispose();

- rejected_promises_.Release();

+ rejected_promises = nullptr;

Yuta Kitamura 2017/05/25 08:19:05 rejected_promises_ ^

world_->Dispose();

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/wtf/RefPtr.h » ('j') | no next file with comments »