Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2907543002: Removed use of RefPtr::Release where result is not used. (Closed)

Created:
3 years, 7 months ago by Bugs Nash
Modified:
3 years, 7 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed use of RefPtr::Release where result is not used. This patch - Removed use of RefPtr::Release where the result is not used. Replaced this with setting the RefPtr to nullptr. - Added WARN_UNUSED_RESULT to RefPtr::Release() to prevent it from being used in this way in future. BUG=494719 Review-Url: https://codereview.chromium.org/2907543002 Cr-Commit-Position: refs/heads/master@{#474903} Committed: https://chromium.googlesource.com/chromium/src/+/f2b5ef577de5bea5bcc93375eeb2e5c4ea4def7f

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/RefPtr.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Bugs Nash
3 years, 7 months ago (2017-05-25 07:00:19 UTC) #4
haraken
LGTM
3 years, 7 months ago (2017-05-25 07:25:37 UTC) #7
Yuta Kitamura
LGTM if the obvious typo is fixed :) https://codereview.chromium.org/2907543002/diff/1/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp File third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp (right): https://codereview.chromium.org/2907543002/diff/1/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp#newcode117 third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp:117: rejected_promises ...
3 years, 7 months ago (2017-05-25 08:19:05 UTC) #8
Bugs Nash
On 2017/05/25 at 08:19:05, yutak wrote: > LGTM if the obvious typo is fixed :) ...
3 years, 7 months ago (2017-05-25 22:06:47 UTC) #9
Bugs Nash
fixed typo
3 years, 7 months ago (2017-05-25 22:09:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907543002/20001
3 years, 7 months ago (2017-05-25 22:10:20 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 04:04:07 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f2b5ef577de5bea5bcc93375eeb2...

Powered by Google App Engine
This is Rietveld 408576698