fuchsia: add base_paths_fuchsia.cc

fuchsia: add base_paths_fuchsia.cc

I was going to use base_paths_posix.cc originally but it's already a big chain
of #ifdefs, and there's no XDG on Fuchsia, so it didn't seem that helpful.

BUG=706592, 726124
Review-Url: https://codereview.chromium.org/2907473002
Cr-Commit-Position: refs/heads/master@{#474563}
Committed: https://chromium.googlesource.com/chromium/src/+/1ab7aa8f394ec33c1fd775adbd34f22907cdae05

[scottmg, 2017-05-24 22:57:34]

Description was changed from

==========
fuchsia: make base_paths_posix.cc sort of work

BUG=706592,726124
==========

to

==========
fuchsia: add base_paths_fuchsia.cc

BUG=706592,726124
==========

[scottmg, 2017-05-24 22:58:26]

Description was changed from

==========
fuchsia: add base_paths_fuchsia.cc

BUG=706592,726124
==========

to

==========
fuchsia: add base_paths_fuchsia.cc

I was going to use base_paths_posix.cc but it's already a big
chain of #ifdefs, and there's no XDG on Fuchsia, so it didn't
seem that helpful.

BUG=706592,726124
==========

[scottmg, 2017-05-24 22:58:42]

Description was changed from

==========
fuchsia: add base_paths_fuchsia.cc

I was going to use base_paths_posix.cc but it's already a big
chain of #ifdefs, and there's no XDG on Fuchsia, so it didn't
seem that helpful.

BUG=706592,726124
==========

to

==========
fuchsia: add base_paths_fuchsia.cc

I was going to use base_paths_posix.cc originally but it's already a big chain
of #ifdefs, and there's no XDG on Fuchsia, so it didn't seem that helpful.

BUG=706592,726124
==========

[scottmg, 2017-05-24 22:59:40]

scottmg@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2017-05-24 23:28:34]

https://codereview.chromium.org/2907473002/diff/20001/base/path_service.cc
File base/path_service.cc (right):

https://codereview.chromium.org/2907473002/diff/20001/base/path_service.cc#ne...
base/path_service.cc:104: 0, 0,
Do you want to actually reserve some number space now? Do it later?

https://codereview.chromium.org/2907473002/diff/20001/base/path_service_unitt...
File base/path_service_unittest.cc (right):

https://codereview.chromium.org/2907473002/diff/20001/base/path_service_unitt...
base/path_service_unittest.cc:33: #if defined(OS_POSIX) && !defined(OS_FUCHSIA)
Are we going to eventually testing Fuchsia here? Do we have a bug for that?

[scottmg, 2017-05-24 23:42:30]

(I might be confused, sorry)

https://codereview.chromium.org/2907473002/diff/20001/base/path_service.cc
File base/path_service.cc (right):

https://codereview.chromium.org/2907473002/diff/20001/base/path_service.cc#ne...
base/path_service.cc:104: 0, 0,
On 2017/05/24 23:28:34, Lei Zhang wrote:
> Do you want to actually reserve some number space now? Do it later?

I only know of /system and /data at the moment. It looks like there's a user
data store in the works, but I don't think it exists yet. So I guess we can add
it as necessary instead of upfront.

https://codereview.chromium.org/2907473002/diff/20001/base/path_service_unitt...
File base/path_service_unittest.cc (right):

https://codereview.chromium.org/2907473002/diff/20001/base/path_service_unitt...
base/path_service_unittest.cc:33: #if defined(OS_POSIX) && !defined(OS_FUCHSIA)
On 2017/05/24 23:28:34, Lei Zhang wrote:
> Are we going to eventually testing Fuchsia here? Do we have a bug for that?

This should test all paths that go through here, right? (Because it defaults to
check_path_exists = true).

I think that'll fail once we can actually link, but...

https://codereview.chromium.org/2907473002/diff/20001/base/path_service_unitt...
base/path_service_unittest.cc:118: #elif defined(OS_POSIX) &&
!defined(OS_FUCHSIA)
This part just avoids testing the POSIX_ specific bits, but we don't have any
FUCHSIA_ specific ones. The general ones are tested above in the first common
loop.

[Lei Zhang, 2017-05-25 00:19:12]

On 2017/05/24 23:42:30, scottmg wrote:
> (I might be confused, sorry)

No, it's me not reading this carefully and asking bad questions. Since there's
no base_paths_fuchsia.h yet, there's no DIR_CACHE or anything else special for
Fuchsia.

lgtm

[scottmg, 2017-05-25 00:19:55]

Thanks!

[scottmg, 2017-05-25 01:55:06]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2017-05-25 01:55:06]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2907473002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-25 01:55:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 05:22:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495677306303020,
"parent_rev": "061c4fcc1f90b46813ff20a639bdfcfe790902db", "commit_rev":
"1ab7aa8f394ec33c1fd775adbd34f22907cdae05"}

[commit-bot: I haz the power, 2017-05-25 05:23:06]

Description was changed from

==========
fuchsia: add base_paths_fuchsia.cc

I was going to use base_paths_posix.cc originally but it's already a big chain
of #ifdefs, and there's no XDG on Fuchsia, so it didn't seem that helpful.

BUG=706592,726124
==========

to

==========
fuchsia: add base_paths_fuchsia.cc

I was going to use base_paths_posix.cc originally but it's already a big chain
of #ifdefs, and there's no XDG on Fuchsia, so it didn't seem that helpful.

BUG=706592,726124

Review-Url: https://codereview.chromium.org/2907473002
Cr-Commit-Position: refs/heads/master@{#474563}
Committed:
https://chromium.googlesource.com/chromium/src/+/1ab7aa8f394ec33c1fd775adbd34...
==========

[commit-bot: I haz the power, 2017-05-25 05:23:07]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1ab7aa8f394ec33c1fd775adbd34...