Update PKITs test data to include "user_constrained_policy_set".

Update PKITs test data to include "user_constrained_policy_set".

BUG=634456, 634453
Review-Url: https://codereview.chromium.org/2907353002
Cr-Commit-Position: refs/heads/master@{#476145}
Committed: https://chromium.googlesource.com/chromium/src/+/8cb1774575276a4e506ffed6270b5f14415c6f6a

[eroman, 2017-05-30 06:38:42]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 06:39:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-05-30 06:49:18]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[commit-bot: I haz the power, 2017-05-30 07:29:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 07:29:47]

Dry run: This issue passed the CQ dry run.

[mattm, 2017-05-30 19:28:21]

https://codereview.chromium.org/2907353002/diff/1/net/third_party/nist-pkits/...
File net/third_party/nist-pkits/generate_tests.py (right):

https://codereview.chromium.org/2907353002/diff/1/net/third_party/nist-pkits/...
net/third_party/nist-pkits/generate_tests.py:245: user_constrained_policy_set =
[TEST_POLICY_1]):
doesn't setting the default here mean the (info.user_constrained_policy_set !=
default_info.user_constrained_policy_set)
check in output_test will never output NIST-test-policy-1 for the user
constrained policy set?

https://codereview.chromium.org/2907353002/diff/1/net/third_party/nist-pkits/...
net/third_party/nist-pkits/generate_tests.py:1128: # mismatch, and expect
user_constrained_policy_set to be empty.
comment isn't really clear to me. Is it because of setting TEST_POLICY_1 as the
default above?

[eroman, 2017-05-30 19:48:59]

https://codereview.chromium.org/2907353002/diff/1/net/third_party/nist-pkits/...
File net/third_party/nist-pkits/generate_tests.py (right):

https://codereview.chromium.org/2907353002/diff/1/net/third_party/nist-pkits/...
net/third_party/nist-pkits/generate_tests.py:245: user_constrained_policy_set =
[TEST_POLICY_1]):
On 2017/05/30 19:28:21, mattm wrote:
> doesn't setting the default here mean the (info.user_constrained_policy_set !=
> default_info.user_constrained_policy_set)
> check in output_test will never output NIST-test-policy-1 for the user
> constrained policy set?

Correct.

It works because the defaults in this file are mirrorred in
PkitsTestInfo::PkitsTestInfo (net/cert/internal/nist_pkits_unittest.cc).

So the resulting PkitsTestInfo that gets built on the C++ will contain
user_constrained_policy_set={testPolicy1} as expected.

I opted to duplicate the defaults to make the generated test case code more
concise (and only highlight the ways in which inputs/outputs differ from the
defaults, similar to the test description).

However if you think this terseness is not desirable I can fully specify the
test inputs/outputs in the generator script and remove the duplicated defaults.

https://codereview.chromium.org/2907353002/diff/1/net/third_party/nist-pkits/...
net/third_party/nist-pkits/generate_tests.py:1128: # mismatch, and expect
user_constrained_policy_set to be empty.
On 2017/05/30 19:28:21, mattm wrote:
> comment isn't really clear to me. Is it because of setting TEST_POLICY_1 as
the
> default above?

I have updated the comment, hopefully it is clearer now.

[eroman, 2017-05-30 19:49:59]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 19:50:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 21:04:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 21:04:30]

Dry run: This issue passed the CQ dry run.

[mattm, 2017-05-31 23:10:35]

lgtm w/nit

https://codereview.chromium.org/2907353002/diff/20001/net/cert/internal/nist_...
File net/cert/internal/nist_pkits_unittest.h (right):

https://codereview.chromium.org/2907353002/diff/20001/net/cert/internal/nist_...
net/cert/internal/nist_pkits_unittest.h:30: // "anyPolicy" and
"NIST-test-policy-1".
Add a note that if this isn't called the default is "NIST-test-policy-1".

[eroman, 2017-05-31 23:51:09]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 23:51:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-05-31 23:53:56]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[eroman, 2017-05-31 23:54:20]

Thanks for the review!

https://codereview.chromium.org/2907353002/diff/20001/net/cert/internal/nist_...
File net/cert/internal/nist_pkits_unittest.h (right):

https://codereview.chromium.org/2907353002/diff/20001/net/cert/internal/nist_...
net/cert/internal/nist_pkits_unittest.h:30: // "anyPolicy" and
"NIST-test-policy-1".
On 2017/05/31 23:10:35, mattm wrote:
> Add a note that if this isn't called the default is "NIST-test-policy-1".

Done.

[commit-bot: I haz the power, 2017-05-31 23:54:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 00:53:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 00:53:31]

Dry run: This issue passed the CQ dry run.

[eroman, 2017-06-01 01:52:57]

The CQ bit was checked by eroman@chromium.org

[eroman, 2017-06-01 01:52:58]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2907353002/#ps60001
(title: "re-run generator script")

[commit-bot: I haz the power, 2017-06-01 01:53:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 01:57:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496281977669840,
"parent_rev": "d2ec4830b36d30ebf8ab495d18a6282db1020db1", "commit_rev":
"8cb1774575276a4e506ffed6270b5f14415c6f6a"}

[commit-bot: I haz the power, 2017-06-01 01:57:56]

Description was changed from

==========
Update PKITs test data to include "user_constrained_policy_set".

BUG=634456,634453
==========

to

==========
Update PKITs test data to include "user_constrained_policy_set".

BUG=634456,634453

Review-Url: https://codereview.chromium.org/2907353002
Cr-Commit-Position: refs/heads/master@{#476145}
Committed:
https://chromium.googlesource.com/chromium/src/+/8cb1774575276a4e506ffed6270b...
==========

[commit-bot: I haz the power, 2017-06-01 01:57:57]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8cb1774575276a4e506ffed6270b...