Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2907343002: Generate getters/setters for text-stroke-width. (Closed)

Created:
3 years, 6 months ago by nainar
Modified:
3 years, 6 months ago
Reviewers:
dstockwell, shend, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate getters/setters for text-stroke-width. Currently, the text-stroke-width property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'primitive' field so that its getters/setters can be generated as well. BUG=628043 Review-Url: https://codereview.chromium.org/2907343002 Cr-Commit-Position: refs/heads/master@{#475461} Committed: https://chromium.googlesource.com/chromium/src/+/fe4dab40075a213e695cd2a3a503356c2e6e8333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
shend
lgtm
3 years, 6 months ago (2017-05-30 05:04:58 UTC) #4
nainar
3 years, 6 months ago (2017-05-30 05:05:21 UTC) #6
rune
rs lgtm
3 years, 6 months ago (2017-05-30 08:06:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907343002/1
3 years, 6 months ago (2017-05-30 08:11:30 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 08:14:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe4dab40075a213e695cd2a3a503...

Powered by Google App Engine
This is Rietveld 408576698