Use multi-value switch to enable/disable the unified gesture detector.

Use multi-value switch to enable/disable the unified gesture detector.

BUG=332418
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272652

[tdresser, 2014-05-22 13:54:15]

sadrul@, PTAL.
This is just to make it easier to toggle the unified GR on and off (by changing
the default behavior).

[sadrul, 2014-05-22 18:45:25]

https://codereview.chromium.org/290733013/diff/1/ui/aura/gestures/gesture_rec...
File ui/aura/gestures/gesture_recognizer_unittest.cc (right):

https://codereview.chromium.org/290733013/diff/1/ui/aura/gestures/gesture_rec...
ui/aura/gestures/gesture_recognizer_unittest.cc:686:
switches::kUnifiedGestureDetector);
Should you use AppendSwitchASCII(Detector, UsingUnifiedGR() ? Enabled :
Disabled) instead?

https://codereview.chromium.org/290733013/diff/1/ui/events/gestures/gesture_r...
File ui/events/gestures/gesture_recognizer_impl.cc (right):

https://codereview.chromium.org/290733013/diff/1/ui/events/gestures/gesture_r...
ui/events/gestures/gesture_recognizer_impl.cc:86: use_unified_gesture_detector_
= false;
Can you do:

  const bool kUseUnifiedDefault = false;
  if (switch empty or enabled) use_unified = true;
  else if (switch disabled) use_unified = false;
  else use_unified = kUseUnifiedDefault;

That way, switching the default would involve changing just the const bool's
value.

[tdresser, 2014-05-22 19:13:04]

Thanks.

https://codereview.chromium.org/290733013/diff/1/ui/aura/gestures/gesture_rec...
File ui/aura/gestures/gesture_recognizer_unittest.cc (right):

https://codereview.chromium.org/290733013/diff/1/ui/aura/gestures/gesture_rec...
ui/aura/gestures/gesture_recognizer_unittest.cc:686:
switches::kUnifiedGestureDetector);
On 2014/05/22 18:45:25, sadrul wrote:
> Should you use AppendSwitchASCII(Detector, UsingUnifiedGR() ? Enabled :
> Disabled) instead?

Done.

https://codereview.chromium.org/290733013/diff/1/ui/events/gestures/gesture_r...
File ui/events/gestures/gesture_recognizer_impl.cc (right):

https://codereview.chromium.org/290733013/diff/1/ui/events/gestures/gesture_r...
ui/events/gestures/gesture_recognizer_impl.cc:86: use_unified_gesture_detector_
= false;
On 2014/05/22 18:45:25, sadrul wrote:
> Can you do:
> 
>   const bool kUseUnifiedDefault = false;
>   if (switch empty or enabled) use_unified = true;
>   else if (switch disabled) use_unified = false;
>   else use_unified = kUseUnifiedDefault;
> 
> That way, switching the default would involve changing just the const bool's
> value.
>   

Done.

[sadrul, 2014-05-22 20:03:23]

https://codereview.chromium.org/290733013/diff/20001/ui/aura/gestures/gesture...
File ui/aura/gestures/gesture_recognizer_unittest.cc (right):

https://codereview.chromium.org/290733013/diff/20001/ui/aura/gestures/gesture...
ui/aura/gestures/gesture_recognizer_unittest.cc:686: :
switches::kUnifiedGestureDetectorDisabled);
Does this actually work? Because you should be using AppendSwitchASCII to set
the kUUGD flag with enabled/disabled values.

[tdresser, 2014-05-22 20:12:36]

https://codereview.chromium.org/290733013/diff/20001/ui/aura/gestures/gesture...
File ui/aura/gestures/gesture_recognizer_unittest.cc (right):

https://codereview.chromium.org/290733013/diff/20001/ui/aura/gestures/gesture...
ui/aura/gestures/gesture_recognizer_unittest.cc:686: :
switches::kUnifiedGestureDetectorDisabled);
On 2014/05/22 20:03:23, sadrul wrote:
> Does this actually work? Because you should be using AppendSwitchASCII to set
> the kUUGD flag with enabled/disabled values.

Ack, of course not...

Thanks, fixed (and verified).

[sadrul, 2014-05-23 15:07:02]

LGTM

[tdresser, 2014-05-23 15:52:06]

The CQ bit was checked by tdresser@chromium.org

[commit-bot: I haz the power, 2014-05-23 15:53:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdresser@chromium.org/290733013/40001

[commit-bot: I haz the power, 2014-05-23 21:06:05]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-24 00:27:51]

Change committed as 272652