Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: ui/aura/gestures/gesture_recognizer_unittest.cc

Issue 290733013: Use multi-value switch to enable/disable the unified gesture detector. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address sadrul's feedback. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | ui/events/event_switches.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/memory/scoped_vector.h" 6 #include "base/memory/scoped_vector.h"
7 #include "base/run_loop.h" 7 #include "base/run_loop.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/timer/timer.h" 9 #include "base/timer/timer.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 663 matching lines...) Expand 10 before | Expand all | Expand 10 after
674 public ::testing::WithParamInterface<bool> { 674 public ::testing::WithParamInterface<bool> {
675 public: 675 public:
676 GestureRecognizerTest() {} 676 GestureRecognizerTest() {}
677 677
678 bool UsingUnifiedGR() { 678 bool UsingUnifiedGR() {
679 return GetParam(); 679 return GetParam();
680 } 680 }
681 681
682 virtual void SetUp() OVERRIDE { 682 virtual void SetUp() OVERRIDE {
683 // TODO(tdresser): Once unified GR has landed, only run these tests once. 683 // TODO(tdresser): Once unified GR has landed, only run these tests once.
684 if (UsingUnifiedGR()) { 684 CommandLine::ForCurrentProcess()->AppendSwitch(
685 CommandLine::ForCurrentProcess()->AppendSwitch( 685 UsingUnifiedGR() ? switches::kUnifiedGestureDetectorEnabled
686 switches::kUseUnifiedGestureDetector); 686 : switches::kUnifiedGestureDetectorDisabled);
sadrul 2014/05/22 20:03:23 Does this actually work? Because you should be usi
tdresser 2014/05/22 20:12:36 Ack, of course not... Thanks, fixed (and verified
687 }
688 687
689 AuraTestBase::SetUp(); 688 AuraTestBase::SetUp();
690 } 689 }
691 690
692 virtual void TearDown() OVERRIDE { 691 virtual void TearDown() OVERRIDE {
693 AuraTestBase::TearDown(); 692 AuraTestBase::TearDown();
694 RunAllPendingInMessageLoop(); 693 RunAllPendingInMessageLoop();
695 } 694 }
696 695
697 DISALLOW_COPY_AND_ASSIGN(GestureRecognizerTest); 696 DISALLOW_COPY_AND_ASSIGN(GestureRecognizerTest);
(...skipping 3570 matching lines...) Expand 10 before | Expand all | Expand 10 after
4268 } 4267 }
4269 4268
4270 // TODO - re-enable these tests once memory management issues have been sorted 4269 // TODO - re-enable these tests once memory management issues have been sorted
4271 // out. See crbug.com/371990. 4270 // out. See crbug.com/371990.
4272 INSTANTIATE_TEST_CASE_P(GestureRecognizer, 4271 INSTANTIATE_TEST_CASE_P(GestureRecognizer,
4273 GestureRecognizerTest, 4272 GestureRecognizerTest,
4274 ::testing::Bool()); 4273 ::testing::Bool());
4275 4274
4276 } // namespace test 4275 } // namespace test
4277 } // namespace aura 4276 } // namespace aura
OLDNEW
« no previous file with comments | « no previous file | ui/events/event_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698