remove oauth from extension install dialog

remove oauth from extension install dialog

The chrome.identity.getAuthToken API now uses a totally separate dialog for displaying its permissions, so the ExtensionInstallDialog implementation can be deleted.

BUG=304836
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272365

[Michael Courage, 2014-05-21 22:53:19]

finnur:
  chrome\browser\extensions\extension_install_prompt.cc
  chrome\browser\extensions\extension_install_prompt.h
  chrome\browser\ui\views\extensions\extension_install_dialog_view.cc
thakis:
  chrome\browser\ui\cocoa\extensions\extension_install_view_controller.h
  chrome\browser\ui\cocoa\extensions\extension_install_view_controller.mm
  chrome\browser\ui\cocoa\extensions\extension_install_view_controller_unittest.
mm

[Nico, 2014-05-21 23:00:16]

cocoa/ lgtm

[Finnur, 2014-05-22 10:35:53]

LGTM.

What is the status on http://crbug.com/277117 ?

Also, out of curiosity... As I recall, this OAuth dialog was taking input
directly from Google servers and showing it in the dialog (with HTML code
visible and all). Is that taken care of in the new dialogs?

[Michael Courage, 2014-05-22 16:35:57]

On 2014/05/22 10:35:53, Finnur wrote:
> LGTM.
> 
> What is the status on http://crbug.com/277117 ?

Fixed (I need to be better at marking these)
 
> Also, out of curiosity... As I recall, this OAuth dialog was taking input
> directly from Google servers and showing it in the dialog (with HTML code
> visible and all). Is that taken care of in the new dialogs?

Yes, the new dialogs use a webview to display permission prompts

[Michael Courage, 2014-05-22 16:36:07]

The CQ bit was checked by courage@chromium.org

[commit-bot: I haz the power, 2014-05-22 16:38:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/courage@chromium.org/290733006/1

[commit-bot: I haz the power, 2014-05-22 20:20:21]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-22 20:26:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 20:26:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Michael Courage, 2014-05-22 20:54:35]

The CQ bit was checked by courage@chromium.org

[commit-bot: I haz the power, 2014-05-22 20:55:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/courage@chromium.org/290733006/20001

[commit-bot: I haz the power, 2014-05-22 23:43:26]

Change committed as 272365