Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3460)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm

Issue 290733006: remove oauth from extension install dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
index c5dcfac5e4249d83979be91a0038eaeaeb75f5a9..e23ac4fd1aeafe443f2522618ce81c852bda00f7 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
@@ -262,48 +262,6 @@ TEST_F(ExtensionInstallViewControllerTest, BasicsInline) {
EXPECT_TRUE([[controller warningsSeparator] isHidden]);
}
-TEST_F(ExtensionInstallViewControllerTest, OAuthIssues) {
- chrome::MockExtensionInstallPromptDelegate delegate;
-
- ExtensionInstallPrompt::Prompt prompt =
- chrome::BuildExtensionInstallPrompt(extension_.get());
- std::vector<base::string16> permissions;
- permissions.push_back(base::UTF8ToUTF16("warning 1"));
- prompt.SetPermissions(permissions);
- // No details provided with this permission.
- std::vector<base::string16> details;
- details.push_back(base::string16());
- prompt.SetPermissionsDetails(details);
-
- IssueAdviceInfoEntry issue;
- issue.description = base::UTF8ToUTF16("issue description 1");
- issue.details.push_back(base::UTF8ToUTF16("issue detail 1"));
- IssueAdviceInfo issues;
- issues.push_back(issue);
- prompt.SetOAuthIssueAdvice(issues);
- prompt.SetIsShowingDetails(
- ExtensionInstallPrompt::OAUTH_DETAILS, 0, true);
-
- base::scoped_nsobject<ExtensionInstallViewController> controller(
- [[ExtensionInstallViewController alloc] initWithNavigator:browser()
- delegate:&delegate
- prompt:prompt]);
-
- [controller view]; // Force nib load.
- NSOutlineView* outlineView = [controller outlineView];
- EXPECT_TRUE(outlineView);
- EXPECT_EQ(6, [outlineView numberOfRows]);
- EXPECT_NSEQ(base::SysUTF16ToNSString(prompt.GetOAuthIssue(0).description),
- [[outlineView dataSource] outlineView:outlineView
- objectValueForTableColumn:nil
- byItem:[outlineView itemAtRow:3]]);
-
- EXPECT_NSEQ(base::SysUTF16ToNSString(prompt.GetOAuthIssue(0).details[0]),
- [[outlineView dataSource] outlineView:outlineView
- objectValueForTableColumn:nil
- byItem:[outlineView itemAtRow:4]]);
-}
-
TEST_F(ExtensionInstallViewControllerTest, PostInstallPermissionsPrompt) {
chrome::MockExtensionInstallPromptDelegate delegate;

Powered by Google App Engine
This is Rietveld 408576698