Don't spin the loading indicator for in-page navigations.

Don't spin the loading indicator for in-page navigations.

BUG=50298
TEST=as in bug.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272093

[Nico, 2014-05-20 21:25:31]

Nice!

https://codereview.chromium.org/290733004/diff/1/content/public/browser/web_c...
File content/public/browser/web_contents.h (right):

https://codereview.chromium.org/290733004/diff/1/content/public/browser/web_c...
content/public/browser/web_contents.h:266: virtual bool
IsLoadToDifferentDocument() const = 0;
All callers of this check for `IsLoading() && IsLoadToDifferentDocument()`.
Should this be IsLoadingToDifferentDocument() and only return true if
IsLoading() returns true too? Then you don't need to duplicate that and in many
places.

[Avi (use Gerrit), 2014-05-20 22:00:41]

https://codereview.chromium.org/290733004/diff/1/content/public/browser/web_c...
File content/public/browser/web_contents.h (right):

https://codereview.chromium.org/290733004/diff/1/content/public/browser/web_c...
content/public/browser/web_contents.h:266: virtual bool
IsLoadToDifferentDocument() const = 0;
On 2014/05/20 21:25:31, Nico wrote:
> All callers of this check for `IsLoading() && IsLoadToDifferentDocument()`.
> Should this be IsLoadingToDifferentDocument() and only return true if
> IsLoading() returns true too? Then you don't need to duplicate that and in
many
> places.

That's actually not true; IsWaitingForResponse is gated as well. Then again, no
one uses IsWaitingForResponse except along with IsLoadToDifferentDocument.

[Nico, 2014-05-21 20:53:30]

lgtm, I like patch set 2 much better

[Avi (use Gerrit), 2014-05-21 20:54:21]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-05-21 20:55:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/avi@chromium.org/290733004/20001

[commit-bot: I haz the power, 2014-05-22 04:18:08]

Change committed as 272093