chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc - Issue 290733004: Don't spin the loading indicator for in-page navigations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

Issue 290733004: Don't spin the loading indicator for in-page navigations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: better? Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

diff --git a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

index f88871dc5149f53c20676153dbd3832bc0dca539..846d805bdac2c05a600d44d195d1ca301e56f5ba 100644

--- a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

+++ b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

@@ -52,7 +52,7 @@ namespace {

TabRendererData::NetworkState TabContentsNetworkState(

WebContents* contents) {

- if (!contents || !contents->IsLoading())

+ if (!contents || !contents->IsLoadingToDifferentDocument())

return TabRendererData::NETWORK_STATE_NONE;

if (contents->IsWaitingForResponse())

return TabRendererData::NETWORK_STATE_WAITING;