Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Then favored DCHECK_CURRENTLY_ON(UI) per reviewer request.

And ultimately used ThreadChecker per https://codereview.chromium.org/2907253003/#msg37.

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
TBR=sorin, pauljensen

Review-Url: https://codereview.chromium.org/2907253003
Cr-Commit-Position: refs/heads/master@{#476684}
Committed: https://chromium.googlesource.com/chromium/src/+/99ff1d83a3574b1b689ad35d7a14688eee88f97a

[gab, 2017-05-30 02:46:36]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-05-30 02:46:37]

Hi, this is an automated change made by https://crbug.com/676387#c8 and sharded
across directories for OWNERS.

No human has looked at this specific output yet, see cl description for things
to watch for.

If it LGTY, please CQ.

If it didn't pass CQ dry-run it may be a simple patch failure or an IWYU failure
from having this being a partial CL... please review anyways and a human will
look at the failure (and ping for re-review if anything major is required..). It
is known to compile all targets on Windows at r474679...  manual tweaks will
likely be required to smoothen things off, bear with me!

Thanks!
Gab

[commit-bot: I haz the power, 2017-05-30 02:46:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 03:44:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 03:44:08]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-05-31 13:19:52]

https://codereview.chromium.org/2907253003/diff/1/chrome/browser/profiles/pro...
File chrome/browser/profiles/profile_manager.h (right):

https://codereview.chromium.org/2907253003/diff/1/chrome/browser/profiles/pro...
chrome/browser/profiles/profile_manager.h:429:
SEQUENCE_CHECKER(sequence_checker_);
I would get rid of this completely in favor of
DCHECK_CURRENTLY_ON(BrowserThread::UI) (which is already used in some places
anyway).

[gab, 2017-05-31 16:47:11]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in chrome/browser/profiles in favor of
SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implcitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
==========

to

==========
Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Favored DCHECK_CURRENTLY_ON(UI) per reviewer request in the end.

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
==========

[gab, 2017-05-31 16:47:19]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-05-31 16:47:24]

https://codereview.chromium.org/2907253003/diff/1/chrome/browser/profiles/pro...
File chrome/browser/profiles/profile_manager.h (right):

https://codereview.chromium.org/2907253003/diff/1/chrome/browser/profiles/pro...
chrome/browser/profiles/profile_manager.h:429:
SEQUENCE_CHECKER(sequence_checker_);
On 2017/05/31 13:19:52, Bernhard Bauer wrote:
> I would get rid of this completely in favor of
> DCHECK_CURRENTLY_ON(BrowserThread::UI) (which is already used in some places
> anyway).

Done.

[commit-bot: I haz the power, 2017-05-31 16:47:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2017-05-31 16:54:05]

LGTM, thanks!

[gab, 2017-05-31 17:29:35]

The CQ bit was unchecked by gab@chromium.org

[gab, 2017-05-31 17:29:39]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-05-31 17:30:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 18:35:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 18:35:44]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gab, 2017-05-31 18:54:59]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 18:55:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-05-31 18:57:29]

gab@chromium.org changed reviewers:
+ pauljensen@chromium.org, sorin@chromium.org

[gab, 2017-05-31 18:57:30]

TBR sorin for component_updater/ side-effects
TBR pauljensen for net/ side-effects

TestBrowserThreadBundle should generally be the first member of a test fixture
and it not outliving TestProfilerManager was specifically causing issue in this
CL.

[gab, 2017-05-31 18:57:45]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Favored DCHECK_CURRENTLY_ON(UI) per reviewer request in the end.

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
==========

to

==========
Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Favored DCHECK_CURRENTLY_ON(UI) per reviewer request in the end.

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
TBR=sorin, pauljensen
==========

[gab, 2017-05-31 18:57:50]

The CQ bit was unchecked by gab@chromium.org

[gab, 2017-05-31 18:57:55]

The CQ bit was checked by gab@chromium.org

[gab, 2017-05-31 18:57:55]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2907253003/#ps40001
(title: "TestBrowserThreadBundle as first member in fixtures using
TestingProfileManager")

[commit-bot: I haz the power, 2017-05-31 18:58:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 23:01:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 23:01:37]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Sorin Jianu, 2017-06-01 00:22:02]

lgtm

component updater lgtm

[gab, 2017-06-01 14:12:06]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-06-01 14:12:09]

The CQ bit was checked by gab@chromium.org

[gab, 2017-06-01 14:12:10]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
sorin@chromium.org
Link to the patchset: https://codereview.chromium.org/2907253003/#ps60001
(title: "more TestBrowserThreadBundle re-ordering")

[commit-bot: I haz the power, 2017-06-01 14:12:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-06-01 14:12:37]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Favored DCHECK_CURRENTLY_ON(UI) per reviewer request in the end.

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
TBR=sorin, pauljensen
==========

to

==========
Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Favored DCHECK_CURRENTLY_ON(UI) per reviewer request in the end.

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
TBR=sorin, pauljensen, sdefresne
==========

[gab, 2017-06-01 14:13:10]

On 2017/05/31 18:57:30, gab wrote:
> TBR sorin for component_updater/ side-effects
> TBR pauljensen for net/ side-effects

+ TBR sdefresne for same nit in chrome\browser\history\android

> 
> TestBrowserThreadBundle should generally be the first member of a test fixture
> and it not outliving TestProfilerManager was specifically causing issue in
this
> CL.

[commit-bot: I haz the power, 2017-06-01 15:01:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 15:01:52]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[gab, 2017-06-01 20:53:31]

I'm going to just use ThreadChecker which will provide the same properties
NonThreadSafe previously did and leave it to the OWNERS to figure out how to
turn this into BrowserThread::UI checks should that matter.

This is making a much bigger mess than I expected per lacking
TestBrowserThreadBundles...

Basically this code in ChromeUnitTestSuiteInitializer::OnTestEnd():

    // AsyncPolicyProvider is a lazily created KeyedService that may need to be
    // shut down here. However, AsyncPolicyProvider::Shutdown() will want to
    // post tasks to delete its policy loaders. This goes through
    // BrowserThreadTaskRunner::PostNonNestableDelayedTask(), which can invoke
    // LazyInstance<BrowserThreadGlobals>::Get() and try to create it for the
    // first time. It might be created during the test, but it might not (see
    // comments in TestingBrowserProcess::browser_policy_connector()). Since
    // creating BrowserThreadGlobals requires creating a SequencedWorkerPool,
    // and that needs a MessageLoop, make sure there is one here so that tests
    // don't get obscure errors. Tests can also invoke TestingBrowserProcess::
    // DeleteInstance() themselves (after ensuring any TestingProfile instances
    // are deleted). But they shouldn't have to worry about that.
    DCHECK(!base::MessageLoop::current());
    base::MessageLoopForUI message_loop;
    TestingBrowserProcess::DeleteInstance();

should probably be using a content::TestBrowserThreadBundle instead of a simpler
base::MessageLoopForUI message_loop, but I don't know if that's right and won't
do this as part of this mass refactor.

Full stack caused by calling TestingBrowserProcess::DeleteInstance() here
outside the main loop/fixture:

[3724:1068:0601/073656.987:7256901:FATAL:profile_manager.cc(386)] Check failed:
::content::BrowserThread::CurrentlyOn(BrowserThread::UI). Must be called on
Chrome_UIThread; actually called on Unknown Thread.
Backtrace:
	base::debug::StackTrace::StackTrace [0x000000014305BB85+69]
	base::debug::StackTrace::StackTrace [0x000000014306DBA3+19]
	logging::LogMessage::~LogMessage [0x0000000142FAE77B+91]
	ProfileManager::~ProfileManager [0x000000014448D102+178]
	`anonymous namespace'::UnittestProfileManager::`scalar deleting destructor'
[0x000000014448D2D4+20]
	TestingBrowserProcess::~TestingBrowserProcess [0x00000001426BDA69+649]
	TestingBrowserProcess::`scalar deleting destructor' [0x00000001426BDB04+20]
	TestingBrowserProcess::DeleteInstance [0x00000001426BDBD2+34]
	ChromeUnitTestSuite::InitializeResourceBundle [0x00000001426C08A9+457]
	testing::internal::TestEventRepeater::OnTestEnd [0x0000000141120C20+64]
	testing::TestInfo::Run [0x0000000141124173+227]
	testing::TestCase::Run [0x0000000141124015+165]
	testing::internal::UnitTestImpl::RunAllTests [0x00000001411244E2+562]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>
[0x0000000141118E4D+61]
	testing::UnitTest::Run [0x0000000141124279+217]
	base::TestSuite::Run [0x00000001426CB5C9+137]
	base::LaunchUnitTests [0x00000001426CE52D+1021]
	base::LaunchUnitTests [0x00000001426CE197+103]
	main [0x0000000145A0A893+215]
	__scrt_common_main_seh [0x00000001459AB0C9+285]
(f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x00000000774859CD+13]
	RtlUserThreadStart [0x00000000775BA561+33]

[gab, 2017-06-01 21:01:29]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-06-01 21:01:51]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Favored DCHECK_CURRENTLY_ON(UI) per reviewer request in the end.

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
TBR=sorin, pauljensen, sdefresne
==========

to

==========
Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Favored DCHECK_CURRENTLY_ON(UI) per reviewer request in the end.

And ultimately used ThreadChecker per
https://codereview.chromium.org/2907253003/#msg37

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
TBR=sorin, pauljensen, sdefresne
==========

[commit-bot: I haz the power, 2017-06-01 21:01:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-06-01 21:02:05]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Favored DCHECK_CURRENTLY_ON(UI) per reviewer request in the end.

And ultimately used ThreadChecker per
https://codereview.chromium.org/2907253003/#msg37

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
TBR=sorin, pauljensen, sdefresne
==========

to

==========
Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Then favored DCHECK_CURRENTLY_ON(UI) per reviewer request

And ultimately used ThreadChecker per
https://codereview.chromium.org/2907253003/#msg37

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
TBR=sorin, pauljensen, sdefresne
==========

[gab, 2017-06-01 21:02:17]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Then favored DCHECK_CURRENTLY_ON(UI) per reviewer request

And ultimately used ThreadChecker per
https://codereview.chromium.org/2907253003/#msg37

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
TBR=sorin, pauljensen, sdefresne
==========

to

==========
Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Then favored DCHECK_CURRENTLY_ON(UI) per reviewer request.

And ultimately used ThreadChecker per
https://codereview.chromium.org/2907253003/#msg37.

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
TBR=sorin, pauljensen, sdefresne
==========

[gab, 2017-06-01 21:02:42]

The CQ bit was unchecked by gab@chromium.org

[gab, 2017-06-01 21:02:49]

The CQ bit was checked by gab@chromium.org

[gab, 2017-06-01 21:02:50]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
sorin@chromium.org
Link to the patchset: https://codereview.chromium.org/2907253003/#ps80001
(title: "back to ThreadChecker")

[commit-bot: I haz the power, 2017-06-01 21:03:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-06-01 21:04:20]

On 2017/06/01 20:53:31, gab wrote:
> I'm going to just use ThreadChecker which will provide the same properties
> NonThreadSafe previously did and leave it to the OWNERS to figure out how to
> turn this into BrowserThread::UI checks should that matter.
> 
> This is making a much bigger mess than I expected per lacking
> TestBrowserThreadBundles...

I'll leave the existing TestBrowserThreadBundle improvements in as they're more
correct even though no longer explicitly required. Added a TODO to fix this in
the name of chrome/browser/profiles/OWNERS. Thanks!

> 
> Basically this code in ChromeUnitTestSuiteInitializer::OnTestEnd():
> 
>     // AsyncPolicyProvider is a lazily created KeyedService that may need to
be
>     // shut down here. However, AsyncPolicyProvider::Shutdown() will want to
>     // post tasks to delete its policy loaders. This goes through
>     // BrowserThreadTaskRunner::PostNonNestableDelayedTask(), which can invoke
>     // LazyInstance<BrowserThreadGlobals>::Get() and try to create it for the
>     // first time. It might be created during the test, but it might not (see
>     // comments in TestingBrowserProcess::browser_policy_connector()). Since
>     // creating BrowserThreadGlobals requires creating a SequencedWorkerPool,
>     // and that needs a MessageLoop, make sure there is one here so that tests
>     // don't get obscure errors. Tests can also invoke TestingBrowserProcess::
>     // DeleteInstance() themselves (after ensuring any TestingProfile
instances
>     // are deleted). But they shouldn't have to worry about that.
>     DCHECK(!base::MessageLoop::current());
>     base::MessageLoopForUI message_loop;
>     TestingBrowserProcess::DeleteInstance();
> 
> should probably be using a content::TestBrowserThreadBundle instead of a
simpler
> base::MessageLoopForUI message_loop, but I don't know if that's right and
won't
> do this as part of this mass refactor.
> 
> Full stack caused by calling TestingBrowserProcess::DeleteInstance() here
> outside the main loop/fixture:
> 
> [3724:1068:0601/073656.987:7256901:FATAL:profile_manager.cc(386)] Check
failed:
> ::content::BrowserThread::CurrentlyOn(BrowserThread::UI). Must be called on
> Chrome_UIThread; actually called on Unknown Thread.
> Backtrace:
> 	base::debug::StackTrace::StackTrace [0x000000014305BB85+69]
> 	base::debug::StackTrace::StackTrace [0x000000014306DBA3+19]
> 	logging::LogMessage::~LogMessage [0x0000000142FAE77B+91]
> 	ProfileManager::~ProfileManager [0x000000014448D102+178]
> 	`anonymous namespace'::UnittestProfileManager::`scalar deleting destructor'
> [0x000000014448D2D4+20]
> 	TestingBrowserProcess::~TestingBrowserProcess [0x00000001426BDA69+649]
> 	TestingBrowserProcess::`scalar deleting destructor' [0x00000001426BDB04+20]
> 	TestingBrowserProcess::DeleteInstance [0x00000001426BDBD2+34]
> 	ChromeUnitTestSuite::InitializeResourceBundle [0x00000001426C08A9+457]
> 	testing::internal::TestEventRepeater::OnTestEnd [0x0000000141120C20+64]
> 	testing::TestInfo::Run [0x0000000141124173+227]
> 	testing::TestCase::Run [0x0000000141124015+165]
> 	testing::internal::UnitTestImpl::RunAllTests [0x00000001411244E2+562]
>
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>
> [0x0000000141118E4D+61]
> 	testing::UnitTest::Run [0x0000000141124279+217]
> 	base::TestSuite::Run [0x00000001426CB5C9+137]
> 	base::LaunchUnitTests [0x00000001426CE52D+1021]
> 	base::LaunchUnitTests [0x00000001426CE197+103]
> 	main [0x0000000145A0A893+215]
> 	__scrt_common_main_seh [0x00000001459AB0C9+285]
> (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
> 	BaseThreadInitThunk [0x00000000774859CD+13]
> 	RtlUserThreadStart [0x00000000775BA561+33]

[commit-bot: I haz the power, 2017-06-01 23:49:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 23:49:34]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[gab, 2017-06-02 15:29:44]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 15:30:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-06-02 15:30:51]

The CQ bit was checked by gab@chromium.org

[gab, 2017-06-02 15:30:52]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
sorin@chromium.org
Link to the patchset: https://codereview.chromium.org/2907253003/#ps100001
(title: "Android crashes?? Revert improvement to
chrome_network_delegate_unittest.cc...")

[gab, 2017-06-02 15:31:06]

gab@chromium.org changed reviewers:
+ sdefresne@chromium.org

[commit-bot: I haz the power, 2017-06-02 15:31:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-06-02 15:31:26]

On 2017/06/01 14:13:10, gab wrote:
> On 2017/05/31 18:57:30, gab wrote:
> > TBR sorin for component_updater/ side-effects
> > TBR pauljensen for net/ side-effects
> 
> + TBR sdefresne for same nit in chrome\browser\history\android

Oops, actually +sdefresne TBR

> 
> > 
> > TestBrowserThreadBundle should generally be the first member of a test
fixture
> > and it not outliving TestProfilerManager was specifically causing issue in
> this
> > CL.

[sdefresne, 2017-06-02 15:34:08]

lgtm

[sdefresne, 2017-06-02 15:34:25]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Then favored DCHECK_CURRENTLY_ON(UI) per reviewer request.

And ultimately used ThreadChecker per
https://codereview.chromium.org/2907253003/#msg37.

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
TBR=sorin, pauljensen, sdefresne
==========

to

==========
Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Then favored DCHECK_CURRENTLY_ON(UI) per reviewer request.

And ultimately used ThreadChecker per
https://codereview.chromium.org/2907253003/#msg37.

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
TBR=sorin, pauljensen
==========

[commit-bot: I haz the power, 2017-06-02 16:29:14]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1496417451900060,
"parent_rev": "6858b7fa2ae42b6c687589f39dd8c70509cb44ac", "commit_rev":
"99ff1d83a3574b1b689ad35d7a14688eee88f97a"}

[commit-bot: I haz the power, 2017-06-02 16:29:26]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Then favored DCHECK_CURRENTLY_ON(UI) per reviewer request.

And ultimately used ThreadChecker per
https://codereview.chromium.org/2907253003/#msg37.

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
TBR=sorin, pauljensen
==========

to

==========
Replace deprecated base::NonThreadSafe in chrome/browser/profiles.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c8.

Then favored DCHECK_CURRENTLY_ON(UI) per reviewer request.

And ultimately used ThreadChecker per
https://codereview.chromium.org/2907253003/#msg37.

BUG=676387
This CL was uploaded by git cl split.

R=bauerb@chromium.org
TBR=sorin, pauljensen

Review-Url: https://codereview.chromium.org/2907253003
Cr-Commit-Position: refs/heads/master@{#476684}
Committed:
https://chromium.googlesource.com/chromium/src/+/99ff1d83a3574b1b689ad35d7a14...
==========

[commit-bot: I haz the power, 2017-06-02 16:29:28]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/99ff1d83a3574b1b689ad35d7a14...