Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2907193002: Attempt to fix flakiness in svg/animations/animate-local-url.html (Closed)

Created:
3 years, 6 months ago by fs
Modified:
3 years, 6 months ago
Reviewers:
Stephen Chennney
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt to fix flakiness in svg/animations/animate-local-url.html SMIL animations start after the 'load' event has been dispatched, so make sure to schedule the relevant timer after the 'load' event handler has run. TBR=schenney@chromium.org BUG=727257 Review-Url: https://codereview.chromium.org/2907193002 Cr-Commit-Position: refs/heads/master@{#475364} Committed: https://chromium.googlesource.com/chromium/src/+/1af51020c7f360753dd77954fff621e5d1896ea6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/svg/animations/animate-local-url.html View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
fs
3 years, 6 months ago (2017-05-29 16:46:48 UTC) #4
fs
On 2017/05/29 at 16:46:48, fs wrote: > Seeing that today is a US holiday, I'm ...
3 years, 6 months ago (2017-05-29 18:14:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907193002/1
3 years, 6 months ago (2017-05-29 18:15:23 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 18:19:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1af51020c7f360753dd77954fff6...

Powered by Google App Engine
This is Rietveld 408576698