Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2907173002: Remove T:: from ActiveScriptWrappable<T>::DispatchHasPendingActivity() (Closed)

Created:
3 years, 6 months ago by hiroshige
Modified:
3 years, 6 months ago
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove T:: from ActiveScriptWrappable<T>::DispatchHasPendingActivity() Previously, for a class T : public ActiveScriptWrappable<T>, HasPendingActivity() cannot be overridden by the subclasses of T because DispatchHasPendingActivity() calls T::HasPendingActivity(). This CL enables the override by calling HasPendingActivity() instead, as preparation for https://codereview.chromium.org/2905233002/. BUG=383741, 327574, 726091, 726414 Review-Url: https://codereview.chromium.org/2907173002 Cr-Commit-Position: refs/heads/master@{#475480} Committed: https://chromium.googlesource.com/chromium/src/+/44f1ff3ef09322690900c00580c90b841a52d73a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/bindings/ActiveScriptWrappable.h View 1 chunk +1 line, -1 line 1 comment Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (11 generated)
hiroshige
PTAL.
3 years, 6 months ago (2017-05-30 08:51:38 UTC) #7
hiroshige
https://codereview.chromium.org/2907173002/diff/1/third_party/WebKit/Source/platform/bindings/ActiveScriptWrappable.h File third_party/WebKit/Source/platform/bindings/ActiveScriptWrappable.h (right): https://codereview.chromium.org/2907173002/diff/1/third_party/WebKit/Source/platform/bindings/ActiveScriptWrappable.h#newcode52 third_party/WebKit/Source/platform/bindings/ActiveScriptWrappable.h:52: (static_cast<T*>(object)->T::GetExecutionContext)() Not blocking https://codereview.chromium.org/2905233002/ but also IsContextDestroyed() has T::.
3 years, 6 months ago (2017-05-30 08:52:52 UTC) #8
haraken
LGTM
3 years, 6 months ago (2017-05-30 08:54:10 UTC) #9
kouhei (in TOK)
lgtm
3 years, 6 months ago (2017-05-30 08:56:04 UTC) #11
commit-bot: I haz the power
This CL has an open dependency (Issue 2912553002 Patch 1). Please resolve the dependency and ...
3 years, 6 months ago (2017-05-30 08:56:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907173002/1
3 years, 6 months ago (2017-05-30 09:34:52 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 09:38:35 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/44f1ff3ef09322690900c00580c9...

Powered by Google App Engine
This is Rietveld 408576698