GN win: prep_libc and fix tcmalloc linkage

GN win: prep_libc and fix tcmalloc linkage

On top of https://codereview.chromium.org/290633012/

R=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272249

[brettw, 2014-05-17 02:38:37]

lgtm

https://codereview.chromium.org/290713002/diff/60001/base/allocator/BUILD.gn
File base/allocator/BUILD.gn (right):

https://codereview.chromium.org/290713002/diff/60001/base/allocator/BUILD.gn#...
base/allocator/BUILD.gn:167: action("prep_libc") {
Can you avoid nesting targets? I've been wanting to disallow this. Nesting is
actually super confusing since all the sources and such will be inherited in
this case from the outer scope.

[scottmg, 2014-05-17 16:29:16]

https://codereview.chromium.org/290713002/diff/60001/base/allocator/BUILD.gn
File base/allocator/BUILD.gn (right):

https://codereview.chromium.org/290713002/diff/60001/base/allocator/BUILD.gn#...
base/allocator/BUILD.gn:167: action("prep_libc") {
On 2014/05/17 02:38:37, brettw wrote:
> Can you avoid nesting targets? I've been wanting to disallow this. Nesting is
> actually super confusing since all the sources and such will be inherited in
> this case from the outer scope.

OK, I'll do that.

It seems unfortunate to move this out -- it'd be nicer if it was 1) near the one
and only place it's used; 2) could be not-visible to anything in another scope.

[scottmg, 2014-05-17 16:34:39]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-05-17 16:35:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/290713002/80001

[commit-bot: I haz the power, 2014-05-17 20:08:53]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[commit-bot: I haz the power, 2014-05-17 20:11:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-17 20:11:18]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[brettw, 2014-05-17 20:59:18]

On 2014/05/17 16:29:16, scottmg wrote:
> https://codereview.chromium.org/290713002/diff/60001/base/allocator/BUILD.gn
> File base/allocator/BUILD.gn (right):
> 
>
https://codereview.chromium.org/290713002/diff/60001/base/allocator/BUILD.gn#...
> base/allocator/BUILD.gn:167: action("prep_libc") {
> On 2014/05/17 02:38:37, brettw wrote:
> > Can you avoid nesting targets? I've been wanting to disallow this. Nesting
is
> > actually super confusing since all the sources and such will be inherited in
> > this case from the outer scope.
> 
> OK, I'll do that.
> 
> It seems unfortunate to move this out -- it'd be nicer if it was 1) near the
one
> and only place it's used; 2) could be not-visible to anything in another
scope.

Yeah, nesting them like this doesn't affect visibility, the names are in the
same namespace. If you don't want it to be visible to other targets, do
visibility = [ ":thing_that_can_use_it" ]

I considered if we wanted nesting to implicitly do this, but I decided it's
mostly unnecessary complication.

[scottmg, 2014-05-20 19:59:03]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-05-20 20:00:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/290713002/80001

[commit-bot: I haz the power, 2014-05-20 20:08:08]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[commit-bot: I haz the power, 2014-05-20 20:14:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-20 20:14:19]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[scottmg, 2014-05-21 03:11:53]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-05-21 03:13:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/290713002/140001

[commit-bot: I haz the power, 2014-05-21 09:16:46]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[commit-bot: I haz the power, 2014-05-21 09:23:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-21 09:23:22]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[scottmg, 2014-05-21 17:00:57]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-05-21 19:57:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/290713002/200001

[commit-bot: I haz the power, 2014-05-22 02:23:01]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)

[commit-bot: I haz the power, 2014-05-22 10:20:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 10:20:12]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[scottmg, 2014-05-22 18:28:41]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-05-22 18:29:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/290713002/200001

[commit-bot: I haz the power, 2014-05-22 18:38:25]

Change committed as 272249